restore 'builders' typecheck #8778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
requested changes
Jan 19, 2024
There was a problem hiding this comment.
For cherry-pick purposes, could you split this in a separate commit?
There was a problem hiding this comment.
For reference here are the issues I encountered in the release branch
@agoric/vats: ../inter-protocol/test/psm/psm-storage-fixture.js(42,11): error TS2304: Cannot find name 'AnchorOptions'.
@agoric/vats: ../solo/src/vat-http.js(109,61): error TS2554: Expected 0-2 arguments, but got 3.
@agoric/vats: src/core/demoIssuers.js(245,14): error TS2339: Property 'mints' does not exist on type '{ agoricNames: Producer<NameHub>; agoricNamesAdmin: Producer<NameAdmin>; bankManager: Producer<{ getAssetSubscription(): IterableEachTopic<AssetDescriptor>; getRewardDistributorDepositFacet(denom: string, feeKit: AssetIssuerKit<...>): ERef<...>; getModuleAccountAddress(moduleName: string): Promise<...>; addAsset(den...'.
turadg
force-pushed
the
ta/restore-builders-typecheck
branch
from
2113911 to
dce9a24
Compare
turadg
force-pushed
the
ta/restore-builders-typecheck
branch
from
dce9a24 to
755a2f7
Compare
mhofman
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typechecking of
deploy-script-supportwas lost at some point. #8747 (comment)This restores the checking and resolves the errors encountered.
I punted on solving the
makeInstallCachetypes.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations