feat: upgrade interchain stack to ibc5 #8791
Conversation
JimLarson
added
enhancement
|
Made issue #8803 for some post-upgrade changes to remove use of deprecated APIs. We don't need to do them now, but we should do them before a migration where they go away. |
|
Reviewers: please check the cosmos-sdk and ibc-go migration guides as part of your review. |
|
The remaining failing tests are expected failures. Protobuf / breakage because of protobuf compilation target changes, and golangci-lint because of use of deprecated APIs (see #8803 for later cleanup). |
|
The cosmos-sdk module tag will be bumped to the final version once agoric-labs/cosmos-sdk#347 lands. |
|
Adding @mhofman as an optional extra reviewer. |
golang/cosmos/go.mod
Outdated
| // replace broken goleveldb. | ||
| github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 | ||
|
|
||
| // use cometft |
There was a problem hiding this comment.
Just to prove I'm actually paying attention:
| // use cometft | |
| // use cometbft |
Allows it to access some internal struct fields.
This was a replace directive in the cosmos-sdk go.mod file, hence not automatically propagaged.
| @@ -560,6 +567,7 @@ func NewAgoricApp( | |||
| appCodec, keys[icahosttypes.StoreKey], | |||
| app.GetSubspace(icahosttypes.SubModuleName), | |||
| app.IBCKeeper.ChannelKeeper, | |||
| app.IBCKeeper.ChannelKeeper, | |||
There was a problem hiding this comment.
There's a new ICS4Wrapper parameter, for which the channel keeper is the correct default.
| github.com/sasha-s/go-deadlock v0.3.1 // indirect | ||
| github.com/spf13/afero v1.9.2 // indirect | ||
| github.com/spf13/jwalterweatherman v1.1.0 // indirect | ||
| github.com/spf13/pflag v1.0.5 // indirect | ||
| github.com/subosito/gotenv v1.4.1 // indirect | ||
| github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 // indirect | ||
| github.com/syndtr/goleveldb v1.0.1-0.20220721030215-126854af5e6d // indirect |
There was a problem hiding this comment.
Have we figured out what causes this one to be upgraded if cosmos-sdk didn't bump it?
There was a problem hiding this comment.
I think it's some sub-dependency and/or the preference of selecting the latest compatible release. Cosmos-sdk has to override this version with a replace as well.
|
|
||
| // For testing against a local cosmos-sdk or tendermint | ||
| // replace github.com/cosmos/cosmos-sdk => ../../../forks/cosmos-sdk | ||
| // replace github.com/tendermint/tendermint => ../../../forks/tendermint | ||
| // github.com/cosmos/cosmos-sdk => ../../../forks/cosmos-sdk |
There was a problem hiding this comment.
Why did the replace disappear here?
There was a problem hiding this comment.
I changed it to a block construct, starting on line 166, to better match gaia.
feat: upgrade interchain stack to ibc5
feat: upgrade interchain stack to ibc5
feat: upgrade interchain stack to ibc5
refs: #8224
closes: #8719
closes: #8783
Description
Upgrade ibc-go to v5.3.2 (from v4.5.1) , with associated upgrades of cosmos-sdk (0.45.16 to 0.46.16) and cometbft (0.34.27 to 0.34.30).
Security Considerations
Careful code review is required.
Scaling Considerations
Performance testing is required.
Documentation Considerations
N/A
Testing Considerations
More testing notes will be added.
Upgrade Considerations
No major upgrade-time work foreseen.