refactor(golang/cosmos/ante): Align with upstream DeductFeeDecorator #9049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, test for double payment of fee (#9036).
Was retained for testing.
|
Superseded by #9051. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9036
Description
An alternative extension to #9045 as suggested in #9045 (review) (cloning upstream DeductFeeDecorator and extending it to support a
feeCollectorNameargument.Security Considerations
Nothing in particular.
Scaling Considerations
n/a
Documentation Considerations
The code should hopefully be clear about its provenance.
Testing Considerations
@JimLarson suggests an additional test for behavior formerly handled by MempoolFeeDecorator, which I could use help with.
Upgrade Considerations
Should preserve previous behavior and minimize burden to incorporate future upstream changes.