cleanup proposal output from extractor

[turadg]

Description

Running #8624 tests locally I noticed some stray proposal- dirs under packages/builders,

proposal-15nVol:

proposal-3L8KIa:

proposal-6MvISf:

proposal-ASFNbi:

proposal-DAEasg:

proposal-IF2R6f:

proposal-PFlNAb:

proposal-VDCA6y:

proposal-VehBb9:

proposal-cKx6Pc:

proposal-j8af9z:
test-vtransfer-plan.json

proposal-kOH4ns:

proposal-lD2hPT:

proposal-nhN3VY:

proposal-onM0Zt:

proposal-peuCWj:

proposal-sGyA41:

proposal-tam6Es:

proposal-yNSjJ7:

proposal-yflqi7:

This makes the extractor delete the whole tmp dir when it's done.

Also refactors for fewer bindings to make the logic more clear.

Security Considerations

n/a, test

Scaling Considerations

n/a, test

Documentation Considerations

No need, reduces surprises

Testing Considerations

CI

Upgrade Considerations

n/a, test

[michaelfig]

LGTM! Just one question that, if the void is the right thing, would be great to justify with a comment in the code.

[michaelfig]

This is the only line I find a little suspect. Does voiding instead of awaiting this promise mean the script might exit before tmpDir is fully removed?

[turadg]

Because it's not awaited, if the Node process reaches termination before it's done I suppose it would be aborted. That seems very unlikely but on the outside chance it's not worth slowing down the test on that file IO.

Is a comment to that effect sufficient or do you think it's worth awaiting?

[turadg]

I'll go with the comment since that was the request