-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start a new auction in a3p-integration #9158
Conversation
44189f6
to
49f7ded
Compare
49f7ded
to
ff78434
Compare
Deploying agoric-sdk with Cloudflare Pages
|
a3p-integration/proposals/a:upgrade-next/priceFeed-follower-auction.test.js
Outdated
Show resolved
Hide resolved
a0da3d9
to
09080d7
Compare
@Chris-Hibbert - This PR appears to be stuck. It's had a merge label for > 24 hours |
1 similar comment
@Chris-Hibbert - This PR appears to be stuck. It's had a merge label for > 24 hours |
3774694
to
2d5a66a
Compare
}, | ||
installation: { | ||
consume: { | ||
auctioneer: auctionInstallation, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make things easier to understand for me, the reason why add-auction
uses the existing auctionInstallation
is to have a new auction vat that uses new instance(s) of priceFeed
since deployed auctioneer isn't upgradable and does NOT have anything to do with replacing auctioneer
with its upgradable version. Am I correct? @Chris-Hibbert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's correct.
refs: #8740
closes: #8918
refs: #8400
Description
Add a new Auction instance in A3P, so #8757 can make use of it. Also provides upgrade proposals which can be be applied to MainNet and other chains.
Security Considerations
N/A
Scaling Considerations
This is largely in service of #8400, which reports that priceFeed vats are accumulating garbage. This PR gives a new auction which can rely on new priceFeeds. The existing auction is not upgradeable and its pricefeeds can't be updated.
Documentation Considerations
No user-visible changes to behavior.
Testing Considerations
Tested in A3P
Upgrade Considerations
Auctions are not upgradeable, so we have to replace them and update their clients.