Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new auction in a3p-integration #9158

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Start a new auction in a3p-integration #9158

merged 7 commits into from
Apr 29, 2024

Conversation

Chris-Hibbert
Copy link
Contributor

refs: #8740
closes: #8918
refs: #8400

Description

Add a new Auction instance in A3P, so #8757 can make use of it. Also provides upgrade proposals which can be be applied to MainNet and other chains.

Security Considerations

N/A

Scaling Considerations

This is largely in service of #8400, which reports that priceFeed vats are accumulating garbage. This PR gives a new auction which can rely on new priceFeeds. The existing auction is not upgradeable and its pricefeeds can't be updated.

Documentation Considerations

No user-visible changes to behavior.

Testing Considerations

Tested in A3P

Upgrade Considerations

Auctions are not upgradeable, so we have to replace them and update their clients.

@Chris-Hibbert Chris-Hibbert self-assigned this Mar 27, 2024
@Chris-Hibbert Chris-Hibbert requested a review from turadg March 28, 2024 16:13
Copy link

cloudflare-workers-and-pages bot commented Apr 12, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2d5a66a
Status: ✅  Deploy successful!
Preview URL: https://f55d337f.agoric-sdk.pages.dev
Branch Preview URL: https://8740-newauction.agoric-sdk.pages.dev

View logs

a3p-integration/package.json Outdated Show resolved Hide resolved
@Chris-Hibbert Chris-Hibbert added the automerge:rebase Automatically rebase updates, then merge label Apr 25, 2024
Copy link

@Chris-Hibbert - This PR appears to be stuck. It's had a merge label for > 24 hours

1 similar comment
Copy link

@Chris-Hibbert - This PR appears to be stuck. It's had a merge label for > 24 hours

@mergify mergify bot merged commit 38b6b62 into master Apr 29, 2024
68 checks passed
@mergify mergify bot deleted the 8740-newAuction branch April 29, 2024 18:36
},
installation: {
consume: {
auctioneer: auctionInstallation,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make things easier to understand for me, the reason why add-auction uses the existing auctionInstallation is to have a new auction vat that uses new instance(s) of priceFeed since deployed auctioneer isn't upgradable and does NOT have anything to do with replacing auctioneer with its upgradable version. Am I correct? @Chris-Hibbert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auction automerge:rebase Automatically rebase updates, then merge contract-upgrade performance Performance related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a coreEval to add a new Auction
3 participants