fix(network): Connection should include negotiated remoteAddress and localAddress
#9186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
commented
Apr 2, 2024
packages/vats/test/test-network.js
Outdated
Comment on lines
195
to
199
| t.is( | ||
| remoteAddress, | ||
| '/ibc-hop/connection-11/ibc-port/port-98/unordered/bar-negotiated/ibc-channel/channel-22', | ||
| ); | ||
| t.is(localAddress, '/ibc-port/port-1/ibc-channel/channel-1'); |
There was a problem hiding this comment.
Before:
remoteAddress: '/ibc-hop/connection-11/ibc-port/port-98/unordered/bar'
localAddress: '/ibc-port/port-1'
There was a problem hiding this comment.
I would even go further, and make it so that localAddress is /ibc-port/port-1/unordered/bar-negotiated/ibc-channel/channel-1. I think that's how (at least) vat-ibc.js behaved at one time.
0xpatrickdev
force-pushed
the
9064-ica-remote-address
branch
2 times, most recently
from
6b6b19f to
0f95805
Compare
6 tasks
0xpatrickdev
force-pushed
the
9064-ica-remote-address
branch
from
38077c8 to
2184ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #9064
Description
After
channelOpenAck, a negotiated version string is returned. WhenConnectionis initiated, it includes the originallocalAddressandremoteAdddressinstead of the negotiated ones.This change propagates the localAddress and remoteAddress already provided to
onConnectPto the Connection initializer,crossoverConnection. If an updated localAddress or remoteAddress is not available, fallback to the original ones fromwatchContext.Before:
After:
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations