fix(ci): move untrusted gh context to envvar #9366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphdev
force-pushed
the
raph/gh-context-env
branch
from
2c397c8 to
c107523
Compare
Deploying agoric-sdk with
|
| Latest commit: |
58fc32e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2f3f2b39.agoric-sdk.pages.dev |
| Branch Preview URL: | https://raph-gh-context-env.agoric-sdk.pages.dev |
LuqiPan
approved these changes
May 14, 2024
mhofman
approved these changes
May 14, 2024
michaelfig
reviewed
May 14, 2024
There was a problem hiding this comment.
Maybe @LuqiPan would know better, but can we search for all attempts to quote template expansion?
fgrep -r '"${{' .github
fgrep -r "'\${{" .github
I've confirmed that this PR will fix all culprits in agoric-sdk repo. I'll start a separate investigation across all of our github organizations. |
raphdev
force-pushed
the
raph/gh-context-env
branch
from
c107523 to
58fc32e
Compare
michaelfig
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mergify workflow directly interpolates elements from GitHub context. While currently there's no significant security implication, we do the recommended practice of storing them in intermediate environment variables.