9281 chainHub exo #9538
Merged
9281 chainHub exo #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
e382b66
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f88922f6.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9281-chainhub-exo.agoric-sdk.pages.dev |
0xpatrickdev
approved these changes
Jun 19, 2024
| @@ -54,7 +54,38 @@ export const connectionKey = (chainId1, chainId2) => { | |||
| return [chainId1, chainId2].sort().join(CHAIN_ID_SEPARATOR); | |||
| }; | |||
|
|
|||
| const ChainIdArgShape = M.or( | |||
There was a problem hiding this comment.
consider:
Suggested change
| const ChainIdArgShape = M.or( | |
| /** accepts `chainId` or `ChainAddress` object */ | |
| const ChainIdArgShape = M.or( |
There was a problem hiding this comment.
good idea. I'll make a note to get that into a future PR
dckc
reviewed
Jun 20, 2024
| M.string(), | ||
| IBCConnectionInfoShape, | ||
| ).returns(), | ||
| getConnectionInfo: M.callWhen(ChainIdArgShape, ChainIdArgShape).returns( |
There was a problem hiding this comment.
callWhen is OK in asyncFlow after all?
I can imagine waiting for tests that show that it's not, but in that case, why not wait for tests that show that chainHub has to be an exo in the 1st place?
There was a problem hiding this comment.
Nope, I learned last night it's not.
We did hit a test failure with the object itself not being durable but only in another branch that had a higher fidelity asyncFlow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9281
Description
AsyncFlow requires that everything passing the membrane is durable. This makes the ChainHub durable by making it an Exo.
Security Considerations
none
Scaling Considerations
It's a singleton, because there will only be one per vat.
Documentation Considerations
none
Testing Considerations
Existing coverage
Upgrade Considerations
Not yet deployed.
Now that it's an Exo, we have to consider its state an upgradability. We expect to make a new one on each vat invocation. The only state it has is cache of AgoricNames and data supplied by the contract.