Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn by corepack #9542

Merged
merged 2 commits into from
Jun 21, 2024
Merged

yarn by corepack #9542

merged 2 commits into from
Jun 21, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Jun 20, 2024

refs: #8461

Description

Rely on corepack for yarn version.

Bump the yarn version to latest.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

I think our docs already say to start with corepack enable. Not certain.

Testing Considerations

  • run locally

Fails if corepack not yet enabled. It should be, so if this change causes errors that would help us to detect. Corepack is important in order to upgrade to Yarn 4 eventually.

Upgrade Considerations

none

@turadg turadg requested review from kriskowal and Jovonni June 20, 2024 17:51
Copy link

cloudflare-workers-and-pages bot commented Jun 20, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2155263
Status: ✅  Deploy successful!
Preview URL: https://27b6a12e.agoric-sdk.pages.dev
Branch Preview URL: https://ta-yarn-corepack.agoric-sdk.pages.dev

View logs

@turadg turadg added automerge:rebase Automatically rebase updates, then merge and removed automerge:rebase Automatically rebase updates, then merge labels Jun 20, 2024
@mergify mergify bot merged commit 52e0339 into master Jun 21, 2024
77 checks passed
@mergify mergify bot deleted the ta/yarn-corepack branch June 21, 2024 15:08
@mhofman
Copy link
Member

mhofman commented Jun 22, 2024

I think our docs already say to start with corepack enable. Not certain.

Our validator docs do not, so I'll skip this in the release for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants