Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vats): support ORACLE_ADDRESSES from environment #9570

Closed
wants to merge 1 commit into from

Conversation

dckc
Copy link
Member

@dckc dckc commented Jun 24, 2024

refs: #9044
refs: #8400
refs: #8740

Description

#9044 supports getting GOV{1,2,3} addresses from the environment, but not the entire ORACLE_ADDRESSES list.
devnet / emerynet / mainnet usage requires specifying a list of more than 3 oracle operator addresses.

Security Considerations

The environment in which the proposal builder is run has to be carefully controlled.

Scaling Considerations

n/a

Documentation Considerations

A comment in priceFeedSupport.js didn't seem right. Rather than delete it, I added another one. This should be cleaned up in due course.

Also, we should

  • confirm that operational stuff around this code is sufficiently documented

Testing Considerations

I presume manual integration testing suffices.

Upgrade Considerations

No additional upgrade considerations.

Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the way. We can't expect all validators to set the same env

@dckc
Copy link
Member Author

dckc commented Jun 24, 2024

This is not the way.

I see.

@dckc dckc closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants