feat(vats): support ORACLE_ADDRESSES from environment #9570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9044
refs: #8400
refs: #8740
Description
#9044 supports getting GOV{1,2,3} addresses from the environment, but not the entire ORACLE_ADDRESSES list.
devnet / emerynet / mainnet usage requires specifying a list of more than 3 oracle operator addresses.
Security Considerations
The environment in which the proposal builder is run has to be carefully controlled.
Scaling Considerations
n/a
Documentation Considerations
A comment in
priceFeedSupport.js
didn't seem right. Rather than delete it, I added another one. This should be cleaned up in due course.Also, we should
Testing Considerations
I presume manual integration testing suffices.
Upgrade Considerations
No additional upgrade considerations.