Proposal to reset fluxAggregator roundIDs for stTIA/stkATOM #9594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
requested changes
Jun 26, 2024
| export const resetRoundId = async ({ | ||
| consume: { chainStorage, chainTimerService }, | ||
| }) => { | ||
| const TOKENS = ['stTIA', 'stkATOM']; |
There was a problem hiding this comment.
How hard would it be to make this a proposal option?
|
|
||
| export default async (homeP, endowments) => { | ||
| const { writeCoreEval } = await makeHelpers(homeP, endowments); | ||
| await writeCoreEval('reest-round-ids', defaultProposalBuilder); |
There was a problem hiding this comment.
Suggested change
| await writeCoreEval('reest-round-ids', defaultProposalBuilder); | |
| await writeCoreEval('reset-round-ids', defaultProposalBuilder); |
Comment on lines
22
to
25
| const tokenStorageNode = await makeStorageNodeChild( | ||
| priceFeedStorageNode, | ||
| name, | ||
| ); |
There was a problem hiding this comment.
I believe the node is in a subchild called latestRound
There was a problem hiding this comment.
thanks. Fixed.
Deploying agoric-sdk with
|
| Latest commit: |
ddf1118
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9275fca3.agoric-sdk.pages.dev |
| Branch Preview URL: | https://cth-resetroundids.agoric-sdk.pages.dev |
mhofman
reviewed
Jun 27, 2024
| tokenStorageNode, | ||
| 'latestRound', | ||
| ); | ||
| const marshalData = makeMarshal(_val => Fail`data only`); |
There was a problem hiding this comment.
Getting a failure here, I believe because of the timer's brand
With slightly different stack as I tweaked a few things on my end:
2024-06-27T06:50:09.257Z SwingSet: vat: v1: coreProposal: resetRoundId
2024-06-27T06:50:09.394Z SwingSet: vat: v1: CORE_EVAL failed: (Error#8)
2024-06-27T06:50:09.395Z SwingSet: vat: v1: Error#8: data only
2024-06-27T06:50:09.396Z SwingSet: vat: v1: Error: data only
at construct ()
at Error (/bundled-source/.../node_modules/ses/src/error/tame-error-constructor.js:56)
at makeError (/bundled-source/.../node_modules/ses/src/error/assert.js:243)
at fail (/bundled-source/.../node_modules/ses/src/error/assert.js:357)
at encodeSlotCommon (.../marshal/src/marshal.js:94)
at encodeSlotToCapData (.../marshal/src/marshal.js:143)
at encodeToCapDataRecur (.../marshal/src/encodeToCapData.js:207)
at (.../marshal/src/encodeToCapData.js:191)
at map ()
at encodeToCapDataRecur (.../marshal/src/encodeToCapData.js:191)
at (.../marshal/src/encodeToCapData.js:191)
at map ()
at encodeToCapDataRecur (.../marshal/src/encodeToCapData.js:191)
at (.../marshal/src/encodeToCapData.js:191)
at map ()
at encodeToCapDataRecur (.../marshal/src/encodeToCapData.js:191)
at encodeToCapData (.../marshal/src/encodeToCapData.js:259)
at toCapData (.../marshal/src/marshal.js:181)
at resetRoundId (.../vats/src/proposals/resetRoundId.js:39)
at ()
at ()
There was a problem hiding this comment.
Found where to pickup a better marshaller.
|
@Chris-Hibbert says this is overtaken by events |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When replacing a priceFeed (see #9044), the oracles find it difficult to reset the roundIDs. We can help by overwriting the vstorage
latestRoundrecord to reset the roundId to zero.Security Considerations
see upgrade.
Scaling Considerations
No impact.
Documentation Considerations
None.
Testing Considerations
We will test in various test networks to ensure that this is the right thing for the oracles.
Upgrade Considerations
When replacing priceFeeds, we need to make it easy for the oracles to know what the current round is. They can read this from vstorage.