build: patch-package in post-install #9627
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNTIL #451
incidental
Description
When running
yarn install
anywhere but the SDK root dir, it won't have patch-package in the postinstall so node_modules sometimes fails to have our patches.For now, add
patch-package
to every package's postinstall. I also tried preventing install directly from subdirs but I didn't find a way to do that without preventing the root install process as well. This narrower approach is better anyway because the whole need will go away with #451.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
This should be removed in the course of #451. That will remove the patch-package dep so it will be obviously necessary to do this.
Testing Considerations
grep -L patch-package packages/*/package.json
comes up emptyUpgrade Considerations
none