offer result vows in smart wallet #9635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
5439ea8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87b385a2.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9308-smart-wallet-vows.agoric-sdk.pages.dev |
turadg
force-pushed
the
9308-smart-wallet-vows
branch
2 times, most recently
from
e23962c to
46b8881
Compare
0xpatrickdev
reviewed
Jul 2, 2024
Comment on lines
+287
to
+288
| // throw so the vow watcher propagates the rejection | ||
| throw reason; |
There was a problem hiding this comment.
Curious how rejections were propagated before - this change seems unrelated to the rest
There was a problem hiding this comment.
the function returned the promise, but now that's wrapped in vow watchers
turadg
force-pushed
the
9308-smart-wallet-vows
branch
from
46b8881 to
8f46beb
Compare
turadg
force-pushed
the
9308-smart-wallet-vows
branch
4 times, most recently
from
10667e2 to
eaf225f
Compare
michaelfig
approved these changes
Jul 4, 2024
Comment on lines
62
to
66
| // FIXME fails if valueVow is restarted | ||
| // t.log('restart valueVow'); | ||
| // await evalProposal( | ||
| // buildProposal('@agoric/builders/scripts/testing/restart-valueVow.js'), | ||
| // ); |
There was a problem hiding this comment.
Did you intend to leave this commented out?
There was a problem hiding this comment.
Oops, bad rebase. This must be tested. Will fixup
- refs: #9308 Co-authored-by: Turadg Aleahmad <turadg@agoric.com>
turadg
force-pushed
the
9308-smart-wallet-vows
branch
from
eaf225f to
5439ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9308
Description
Makes the offer result watcher able to handle offer results that are vows or promises for vows.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
adds a test for a vow resolving after its source vat restarts
Upgrade Considerations
This requires an upgrade of the smart-wallet contract, which will have to be deployed in a core-eval.
adds a smart wallet contract upgrade test