-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scripts): Add npm-dist-tag.sh --otp-stream for a better CLI experience #9658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
gibson042
force-pushed
the
gibson-9079-npm-dist-tag-otp
branch
from
July 6, 2024 17:28
f64c87c
to
9c4c164
Compare
Deploying agoric-sdk with Cloudflare Pages
|
CI is failing in what looks like a trivial (and unrelated) |
michaelfig
approved these changes
Jul 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! LGTM.
gibson042
force-pushed
the
gibson-9079-npm-dist-tag-otp
branch
from
July 7, 2024 17:42
9c4c164
to
5920b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #9079
Description
Refactor npm-dist-tag.sh to improve readability, efficiency, correctness, and most importantly user experience (in particular by avoiding breakouts to browser tabs for entering OTP values with default npm configuration).
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
Usage output and internal comments better explain how to use the script and what it does.
Testing Considerations
Tested manually.
Upgrade Considerations
n/a