Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): Add npm-dist-tag.sh --otp-stream for a better CLI experience #9658

Merged
merged 9 commits into from
Jul 7, 2024

Conversation

gibson042
Copy link
Member

Ref #9079

Description

Refactor npm-dist-tag.sh to improve readability, efficiency, correctness, and most importantly user experience (in particular by avoiding breakouts to browser tabs for entering OTP values with default npm configuration).

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

Usage output and internal comments better explain how to use the script and what it does.

Testing Considerations

Tested manually.

Upgrade Considerations

n/a

@gibson042 gibson042 mentioned this pull request Jul 6, 2024
8 tasks
@gibson042 gibson042 force-pushed the gibson-9079-npm-dist-tag-otp branch from f64c87c to 9c4c164 Compare July 6, 2024 17:28
Copy link

cloudflare-workers-and-pages bot commented Jul 6, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5920b6b
Status: ✅  Deploy successful!
Preview URL: https://566ea972.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-9079-npm-dist-tag-otp.agoric-sdk.pages.dev

View logs

@michaelfig
Copy link
Member

CI is failing in what looks like a trivial (and unrelated) @ts-expect-error in replay-membrane.js. It'll probably clear up after updating to current master.

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! LGTM.

scripts/npm-dist-tag.sh Outdated Show resolved Hide resolved
@gibson042 gibson042 force-pushed the gibson-9079-npm-dist-tag-otp branch from 9c4c164 to 5920b6b Compare July 7, 2024 17:42
@gibson042 gibson042 added the automerge:rebase Automatically rebase updates, then merge label Jul 7, 2024
@mergify mergify bot merged commit 62ea793 into master Jul 7, 2024
84 of 85 checks passed
@mergify mergify bot deleted the gibson-9079-npm-dist-tag-otp branch July 7, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants