test baggage #9659
Merged
test baggage #9659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
fbe4414
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22a2feab.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-baggage-tests.agoric-sdk.pages.dev |
Merged
mergify bot
added a commit
that referenced
this pull request
Jul 8, 2024
_incidental_ ## Description Some cleanups noticed in the course of [#9659](#9659) ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations "Dependency Graph" test has been failing on the recent change to `replay-membrane.js`. Maybe that should be a Required test in the repo. ### Upgrade Considerations This changes Zoe but in a fully backwards and forward compatible way. I think it can get into master and reach chain whenever Zoe is next upgraded.
0xpatrickdev
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
LGTM, although I'm curious what behavior we are testing or what invariants we are trying to uphold.
How should we be evaluating the snapshots? Two things coming to mind -
- userspace keys do not interfere with service level endowments
- baggage contents are available after upgrade
Good questions. In general, I think snapshot tests are valuable for:
Both are helpful right now for the PRs refactoring zones for retriable and a new boilerplate abstraction.
Yes, though I expect that will be maintained by a sub-baggage.
These don't test upgrade per se. I take it you mean that any change observed is backwards compatible. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
Adds a way to test contract baggage, to detect changes.
Security Considerations
Uses the
setTestJigto expose baggage. Safe by design.Scaling Considerations
none
Documentation Considerations
Could be useful at some point
Testing Considerations
CI
Upgrade Considerations
none