improve ChainAddress type #9662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
33f92b5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1930c541.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9162-chainaddress.agoric-sdk.pages.dev |
turadg
force-pushed
the
9162-ChainAddress
branch
2 times, most recently
from
156ce76 to
d79552f
Compare
0xpatrickdev
approved these changes
Jul 7, 2024
| @@ -22,7 +22,7 @@ import type { AmountArg, ChainAddress, DenomAmount } from './types.js'; | |||
|
|
|||
| /** An address for a validator on some blockchain, e.g., cosmos, eth, etc. */ | |||
| export type CosmosValidatorAddress = ChainAddress & { | |||
| // TODO document why this is the format | |||
| // infix for Validator Operator https://docs.cosmos.network/main/learn/beginner/accounts#addresses | |||
There was a problem hiding this comment.
We might consider 1) noting this is valoper conventionally, 2) moving this value to ChainInfo keyed as bech32PrefixValPub
dtribble
approved these changes
Jul 8, 2024
0xpatrickdev
added a commit
that referenced
this pull request
Jul 10, 2024
- fixes changed parameter from #9662 - improves test to print delegate offer result error on failure
0xpatrickdev
added a commit
that referenced
this pull request
Jul 10, 2024
- fixes changed parameter from #9662 - improves test to print delegate offer result error on failure
0xpatrickdev
added a commit
that referenced
this pull request
Jul 10, 2024
- fixes changed parameter from #9662 - improves test to print delegate offer result error on failure
0xpatrickdev
added a commit
that referenced
this pull request
Jul 11, 2024
- fixes changed parameter from #9662 - improves test to print delegate offer result error on failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9162
Description
#9162 is already mostly done. This revisits the property names with some improvements. Also cleans up nearby types and docs.
#9162 (comment) has some good ideas for future directions but this PR wraps up the requirements for release.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations
unreleased