fix(agoric-cli): Fully generalize package name extractor from zip files #9669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
1de3fd4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4d11db2f.agoric-sdk.pages.dev |
| Branch Preview URL: | https://kriskowal-allow-bundle-trebs.agoric-sdk.pages.dev |
turadg
approved these changes
Jul 9, 2024
| @@ -11,7 +11,7 @@ import { ZipReader } from '@endo/zip'; | |||
| /** @import {Bundle} from '@agoric/swingset-vat'; */ | |||
| /** @import {CoreEvalPlan} from '@agoric/deploy-script-support/src/writeCoreEvalParts.js' */ | |||
|
|
|||
| const PACKAGE_NAME_RE = /(?<packageName>.*-v[\d.]+(?:-n\d+)?)\//; | |||
There was a problem hiding this comment.
I find the named capture groups more clear but won't block.
Consider a regression unit test for different name strings observed that have failed.
There was a problem hiding this comment.
Consider a regression unit test for different name strings observed that have failed.
That's what I came back here to add. I'd be willing to add a commit for that if it would help.
There was a problem hiding this comment.
I added some tests. Feel free to add or subtract.
kriskowal
force-pushed
the
kriskowal-allow-bundle-trebs
branch
from
1b38ceb to
fa3c4d4
Compare
kriskowal
force-pushed
the
kriskowal-allow-bundle-trebs
branch
from
fa3c4d4 to
1de3fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #9667 we learn that the bundle analyzer needs to understand exotic package names that include
-dev$hashand such. To that end, this change fully generalizes the package name detector based on the@prefix distinguishing a package name with two path components.Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
None.
Upgrade Considerations
None.