Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Resolve Array.forEach lint warnings #9688

Merged
merged 3 commits into from
Jul 13, 2024

chore: Apply suggestions from code review

363f83f
Select commit
Loading
Failed to load commit list.
Merged

chore: Resolve Array.forEach lint warnings #9688

chore: Apply suggestions from code review
363f83f
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded Jul 13, 2024 in 0s

The pull request embarked with master (986371e) will be merged soon

Required conditions for merge:

  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • base=master
  • all of [📃 From pull request rule rebase updates then merge to master]:
    • -draft [📌 queue requirement]
    • base=master
    • label=automerge:rebase
    • any of [📌 queue -> configuration change requirements]:
      • -mergify-configuration-changed
      • check-success=Configuration changed
    • any of [🔀 queue conditions]:
      • all of [📌 queue conditions of queue main]:
        • #approved-reviews-by>=1 [🛡 GitHub branch protection]
        • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
        • base=master
        • any of:
          • check-success=integration-test-result
          • check-pending=integration-test-result
          • label=bypass:integration
        • any of:
          • all of:
            • -label=proto:expect-breakage
            • check-success=breakage
          • all of:
            • check-failure=breakage
            • label=proto:expect-breakage
        • any of [🛡 GitHub branch protection]:
          • check-success=gotest
          • check-neutral=gotest
          • check-skipped=gotest
        • any of [🛡 GitHub branch protection]:
          • check-success=lint
          • check-neutral=lint
          • check-skipped=lint
        • any of [🛡 GitHub branch protection]:
          • check-success=test-quick (xs)
          • check-neutral=test-quick (xs)
          • check-skipped=test-quick (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-quick2 (xs)
          • check-neutral=test-quick2 (xs)
          • check-skipped=test-quick2 (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-cosmic-swingset (xs)
          • check-neutral=test-cosmic-swingset (xs)
          • check-skipped=test-cosmic-swingset (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-zoe-swingset (xs)
          • check-neutral=test-zoe-swingset (xs)
          • check-skipped=test-zoe-swingset (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-zoe-unit (xs)
          • check-neutral=test-zoe-unit (xs)
          • check-skipped=test-zoe-unit (xs)
        • any of [🛡 GitHub branch protection]:
          • check-success=lint-primary
          • check-neutral=lint-primary
          • check-skipped=lint-primary
        • any of [🛡 GitHub branch protection]:
          • check-success=lint-rest
          • check-neutral=lint-rest
          • check-skipped=lint-rest
        • any of [🛡 GitHub branch protection]:
          • check-success=build (18.x)
          • check-neutral=build (18.x)
          • check-skipped=build (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-cosmic-swingset (18.x)
          • check-neutral=test-cosmic-swingset (18.x)
          • check-skipped=test-cosmic-swingset (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-quick (18.x)
          • check-neutral=test-quick (18.x)
          • check-skipped=test-quick (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-quick2 (18.x)
          • check-neutral=test-quick2 (18.x)
          • check-skipped=test-quick2 (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-solo (18.x)
          • check-neutral=test-solo (18.x)
          • check-skipped=test-solo (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-zoe-unit (18.x)
          • check-neutral=test-zoe-unit (18.x)
          • check-skipped=test-zoe-unit (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-zoe-swingset (18.x)
          • check-neutral=test-zoe-swingset (18.x)
          • check-skipped=test-zoe-swingset (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-inter-protocol (18.x)
          • check-neutral=test-inter-protocol (18.x)
          • check-skipped=test-inter-protocol (18.x)
        • any of [🛡 GitHub branch protection]:
          • check-skipped=linear-history
          • check-neutral=linear-history
          • check-success=linear-history
        • any of [🛡 GitHub branch protection]:
          • check-success=merge-strategy (chosen)
          • check-neutral=merge-strategy (chosen)
          • check-skipped=merge-strategy (chosen)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-boot (18.x, 0, 4)
          • check-neutral=test-boot (18.x, 0, 4)
          • check-skipped=test-boot (18.x, 0, 4)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-boot (18.x, 1, 4)
          • check-neutral=test-boot (18.x, 1, 4)
          • check-skipped=test-boot (18.x, 1, 4)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-boot (18.x, 2, 4)
          • check-neutral=test-boot (18.x, 2, 4)
          • check-skipped=test-boot (18.x, 2, 4)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-boot (18.x, 3, 4)
          • check-neutral=test-boot (18.x, 3, 4)
          • check-skipped=test-boot (18.x, 3, 4)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-boot (xs, 0, 4)
          • check-neutral=test-boot (xs, 0, 4)
          • check-skipped=test-boot (xs, 0, 4)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-boot (xs, 1, 4)
          • check-neutral=test-boot (xs, 1, 4)
          • check-skipped=test-boot (xs, 1, 4)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-boot (xs, 2, 4)
          • check-neutral=test-boot (xs, 2, 4)
          • check-skipped=test-boot (xs, 2, 4)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-boot (xs, 3, 4)
          • check-neutral=test-boot (xs, 3, 4)
          • check-skipped=test-boot (xs, 3, 4)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (xs, 0, 5)
          • check-neutral=test-swingset (xs, 0, 5)
          • check-skipped=test-swingset (xs, 0, 5)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (xs, 1, 5)
          • check-neutral=test-swingset (xs, 1, 5)
          • check-skipped=test-swingset (xs, 1, 5)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (xs, 2, 5)
          • check-neutral=test-swingset (xs, 2, 5)
          • check-skipped=test-swingset (xs, 2, 5)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (xs, 3, 5)
          • check-neutral=test-swingset (xs, 3, 5)
          • check-skipped=test-swingset (xs, 3, 5)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (xs, 4, 5)
          • check-neutral=test-swingset (xs, 4, 5)
          • check-skipped=test-swingset (xs, 4, 5)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (18.x, 0, 5)
          • check-neutral=test-swingset (18.x, 0, 5)
          • check-skipped=test-swingset (18.x, 0, 5)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (18.x, 1, 5)
          • check-neutral=test-swingset (18.x, 1, 5)
          • check-skipped=test-swingset (18.x, 1, 5)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (18.x, 2, 5)
          • check-neutral=test-swingset (18.x, 2, 5)
          • check-skipped=test-swingset (18.x, 2, 5)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (18.x, 3, 5)
          • check-neutral=test-swingset (18.x, 3, 5)
          • check-skipped=test-swingset (18.x, 3, 5)
        • any of [🛡 GitHub branch protection]:
          • check-success=test-swingset (18.x, 4, 5)
          • check-neutral=test-swingset (18.x, 4, 5)
          • check-skipped=test-swingset (18.x, 4, 5)
  • any of:
    • check-success=integration-test-result
    • label=bypass:integration
  • any of [🛡 GitHub branch protection]:
    • check-success=gotest
    • check-neutral=gotest
    • check-skipped=gotest
  • any of [🛡 GitHub branch protection]:
    • check-success=lint
    • check-neutral=lint
    • check-skipped=lint
  • any of [🛡 GitHub branch protection]:
    • check-success=test-quick (xs)
    • check-neutral=test-quick (xs)
    • check-skipped=test-quick (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-quick2 (xs)
    • check-neutral=test-quick2 (xs)
    • check-skipped=test-quick2 (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-cosmic-swingset (xs)
    • check-neutral=test-cosmic-swingset (xs)
    • check-skipped=test-cosmic-swingset (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-zoe-swingset (xs)
    • check-neutral=test-zoe-swingset (xs)
    • check-skipped=test-zoe-swingset (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-zoe-unit (xs)
    • check-neutral=test-zoe-unit (xs)
    • check-skipped=test-zoe-unit (xs)
  • any of [🛡 GitHub branch protection]:
    • check-success=lint-primary
    • check-neutral=lint-primary
    • check-skipped=lint-primary
  • any of [🛡 GitHub branch protection]:
    • check-success=lint-rest
    • check-neutral=lint-rest
    • check-skipped=lint-rest
  • any of [🛡 GitHub branch protection]:
    • check-success=build (18.x)
    • check-neutral=build (18.x)
    • check-skipped=build (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-cosmic-swingset (18.x)
    • check-neutral=test-cosmic-swingset (18.x)
    • check-skipped=test-cosmic-swingset (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-quick (18.x)
    • check-neutral=test-quick (18.x)
    • check-skipped=test-quick (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-quick2 (18.x)
    • check-neutral=test-quick2 (18.x)
    • check-skipped=test-quick2 (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-solo (18.x)
    • check-neutral=test-solo (18.x)
    • check-skipped=test-solo (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-zoe-unit (18.x)
    • check-neutral=test-zoe-unit (18.x)
    • check-skipped=test-zoe-unit (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-zoe-swingset (18.x)
    • check-neutral=test-zoe-swingset (18.x)
    • check-skipped=test-zoe-swingset (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-inter-protocol (18.x)
    • check-neutral=test-inter-protocol (18.x)
    • check-skipped=test-inter-protocol (18.x)
  • any of [🛡 GitHub branch protection]:
    • check-skipped=linear-history
    • check-neutral=linear-history
    • check-success=linear-history
  • any of [🛡 GitHub branch protection]:
    • check-success=merge-strategy (chosen)
    • check-neutral=merge-strategy (chosen)
    • check-skipped=merge-strategy (chosen)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-boot (18.x, 0, 4)
    • check-neutral=test-boot (18.x, 0, 4)
    • check-skipped=test-boot (18.x, 0, 4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-boot (18.x, 1, 4)
    • check-neutral=test-boot (18.x, 1, 4)
    • check-skipped=test-boot (18.x, 1, 4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-boot (18.x, 2, 4)
    • check-neutral=test-boot (18.x, 2, 4)
    • check-skipped=test-boot (18.x, 2, 4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-boot (18.x, 3, 4)
    • check-neutral=test-boot (18.x, 3, 4)
    • check-skipped=test-boot (18.x, 3, 4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-boot (xs, 0, 4)
    • check-neutral=test-boot (xs, 0, 4)
    • check-skipped=test-boot (xs, 0, 4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-boot (xs, 1, 4)
    • check-neutral=test-boot (xs, 1, 4)
    • check-skipped=test-boot (xs, 1, 4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-boot (xs, 2, 4)
    • check-neutral=test-boot (xs, 2, 4)
    • check-skipped=test-boot (xs, 2, 4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-boot (xs, 3, 4)
    • check-neutral=test-boot (xs, 3, 4)
    • check-skipped=test-boot (xs, 3, 4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (xs, 0, 5)
    • check-neutral=test-swingset (xs, 0, 5)
    • check-skipped=test-swingset (xs, 0, 5)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (xs, 1, 5)
    • check-neutral=test-swingset (xs, 1, 5)
    • check-skipped=test-swingset (xs, 1, 5)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (xs, 2, 5)
    • check-neutral=test-swingset (xs, 2, 5)
    • check-skipped=test-swingset (xs, 2, 5)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (xs, 3, 5)
    • check-neutral=test-swingset (xs, 3, 5)
    • check-skipped=test-swingset (xs, 3, 5)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (xs, 4, 5)
    • check-neutral=test-swingset (xs, 4, 5)
    • check-skipped=test-swingset (xs, 4, 5)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (18.x, 0, 5)
    • check-neutral=test-swingset (18.x, 0, 5)
    • check-skipped=test-swingset (18.x, 0, 5)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (18.x, 1, 5)
    • check-neutral=test-swingset (18.x, 1, 5)
    • check-skipped=test-swingset (18.x, 1, 5)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (18.x, 2, 5)
    • check-neutral=test-swingset (18.x, 2, 5)
    • check-skipped=test-swingset (18.x, 2, 5)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (18.x, 3, 5)
    • check-neutral=test-swingset (18.x, 3, 5)
    • check-skipped=test-swingset (18.x, 3, 5)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-swingset (18.x, 4, 5)
    • check-neutral=test-swingset (18.x, 4, 5)
    • check-skipped=test-swingset (18.x, 4, 5)

Check-runs and statuses of the embarked pull request #9688:

linear-history details
Cloudflare Pages — Deployed successfullydetails
breakage details
build (18.x) details
build (20.x) details
codecov/patch — 76.47% of diff hit (target 55.70%)details
codecov/project — 55.70% (+0.00%) compared to 986371edetails
dependency-graph details
deployment-test details
finalize-integration-result details
getting-started (link-cli/yarn) details
getting-started (registry/npm) details
getting-started (registry/npx) details
getting-started (registry/yarn) details
golangci-lint (no-failure) details
gotest details
integration-test-result — Integration Test Aggregate Resultdetails
lint details
lint-primary details
lint-rest details
merge-strategy (chosen) details
pre_check / Check preconditions and cancel previous jobs details
run-scripts-tests details
test-boot (18.x, 0, 4) details
test-boot (18.x, 1, 4) details
test-boot (18.x, 2, 4) details
test-boot (18.x, 3, 4) details
test-boot (20.x, 0, 4) details
test-boot (20.x, 1, 4) details
test-boot (20.x, 2, 4) details
test-boot (20.x, 3, 4) details
test-boot (xs, 0, 4) details
test-boot (xs, 1, 4) details
test-boot (xs, 2, 4) details
test-boot (xs, 3, 4) details
test-cosmic-swingset (18.x) details
test-cosmic-swingset (20.x) details
test-cosmic-swingset (xs) details
test-dapp (18.x) details
test-docker-build details
test-governance (18.x) details
test-governance (20.x) details
test-inter-protocol (18.x) details
test-inter-protocol (20.x) details
test-quick (18.x) details
test-quick (20.x) details
test-quick (xs) details
test-quick2 (18.x) details
test-quick2 (20.x) details
test-quick2 (xs) details
test-solo (18.x) details
test-solo (20.x) details
test-swingset (18.x, 0, 5) details
test-swingset (18.x, 1, 5) details
test-swingset (18.x, 2, 5) details
test-swingset (18.x, 3, 5) details
test-swingset (18.x, 4, 5) details
test-swingset (20.x, 0, 5) details
test-swingset (20.x, 1, 5) details
test-swingset (20.x, 2, 5) details
test-swingset (20.x, 3, 5) details
test-swingset (20.x, 4, 5) details
test-swingset (xs, 0, 5) details
test-swingset (xs, 1, 5) details
test-swingset (xs, 2, 5) details
test-swingset (xs, 3, 5) details
test-swingset (xs, 4, 5) details
test-zoe-swingset (18.x) details
test-zoe-swingset (20.x) details
test-zoe-swingset (xs) details
test-zoe-unit (18.x) details
test-zoe-unit (20.x) details
test-zoe-unit (xs) details
up-to-date details
wait-integration-pre-checks details
View more details on Mergify