9693 lint flow #9726
Merged
9693 lint flow #9726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
1a91e7b
|
| Status: | 🚫 Build failed. |
dckc
approved these changes
Jul 17, 2024
| import { orchestrationFns } from './sendAnywhereFlows.js'; | ||
| import * as flows from './sendAnywhere.flows.js'; |
| const orchFns = orchestrateAll(orchestrationFns, { | ||
| const orchFns = orchestrateAll(flows, { |
mhofman
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Nit: git is not catching this as a rename. Could you split this commit in 2 with minimal changes to the source during the file rename?
There was a problem hiding this comment.
because you want to preserve the git blame on the lines?
There was a problem hiding this comment.
done, but I'll say it didn't seem worth the time to me. the reindenting already touches all the lines.
dckc
approved these changes
Jul 18, 2024
| @@ -35,6 +35,7 @@ import { preparePortfolioHolder } from '../exos/portfolio-holder-kit.js'; | |||
| */ | |||
|
|
|||
| /** | |||
| * @satisfies {OrchestrationFlow} | |||
| @@ -0,0 +1,24 @@ | |||
| /** | |||
| * @file Module with linting errors, to verify the linting config detects them. | |||
| @@ -3,3 +3,18 @@ | |||
| Build feature-rich applications that can orchestrate assets and services across the interchain. | |||
|
|
|||
| Usage examples can be found under [src/examples](https://github.com/Agoric/agoric-sdk/tree/master/packages/orchestration/src/examples). They are exported for integration testing with other packages. | |||
|
|
|||
| ## Orchestration flows | |||
turadg
added a commit
to endojs/endo
that referenced
this pull request
Jul 18, 2024
Refs: Agoric/agoric-sdk#9726 ## Description A new lint rule, `harden-exports`, to support Agoric/agoric-sdk#9726 Includes an autofixer ### Security Considerations Could enhance security ### Scaling Considerations n/a ### Documentation Considerations We don't yet document provided rules: https://endojs.github.io/endo/modules/_endo_eslint_plugin.html I think that's okay for now. If that is requested I'd file it as a separate issue, out of scope of this one. ### Testing Considerations I temporarily enabled this in the **recommended** config and ran `lint-fix` on the repo. All the changes looked correct. However `harden()` isn't always available so I don't think we should enable it in any of Endo's shared configs. ### Compatibility Considerations n/a ### Upgrade Considerations n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9692, #9693
Description
Sets up a convention for
flowsmodules and document in the orchestration README.Also makes lint config to test them. The lint config is exported as a shared config that developers can use. I've included it in the same PR to make sure it works with the new convention.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
Documented the convention in the README. I expect it'll make its way to docs.agoric.com as needed.
Testing Considerations
nothing special
Upgrade Considerations
not yet deployed