ci(getting-started): mitigate registry/yarn flake
#9799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
110326f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cc4ca059.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mfig-deflake-getting-started.agoric-sdk.pages.dev |
michaelfig
force-pushed
the
mfig-deflake-getting-started
branch
4 times, most recently
from
7d7a3cd to
f621ac0
Compare
dckc
reviewed
Jul 31, 2024
| * @param {string} url | ||
| * @returns {Promise<bigint>} | ||
| */ | ||
| const getLatestBlockHeight = url => |
There was a problem hiding this comment.
I wonder how many implementations we have of this by now :)
There was a problem hiding this comment.
It occured to me: I should probably do a pure JS implementation available via the agoric wait-for-block command to subsume the functionality of the waitForBlock shell function and the various polling loops we have in Makefiles, etc.
Comment on lines
+17
to
+19
| // TODO: Set this to `true` when `agoric install $DISTTAG` properly updates the | ||
| // getting-started workflow's dependencies to current `@endo/*` and Agoric SDK | ||
| // from the local registry. |
There was a problem hiding this comment.
seems like this should reference an issue.
I don't see one that's quite on target; closest I find is #8621
There was a problem hiding this comment.
I'll try to add to that issue or create a new one to include as a reference in the TODO.
rabi-siddique
approved these changes
Aug 5, 2024
michaelfig
added
the
automerge:no-update
michaelfig
force-pushed
the
mfig-deflake-getting-started
branch
from
f621ac0 to
4942874
Compare
michaelfig
force-pushed
the
mfig-deflake-getting-started
branch
from
4942874 to
110326f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9325, closes: #9710
Description
This is a minor fix to make sure the
registry/yarngetting-started CI test doesn't fail. It embraces the current situation thatagoric install $DISTTAGis not currently usable within the default Agoric/dapp-offer-up because of the long list ofpackageJson.resolutionsdapp-offer-upuses.Thus,
getting-started.jshasAGORIC_INSTALL_DISTTAGset tofalse. This ensures thatagoric install $DISTTAGdoes not execute. It is replaced by simplyyarn install.