feat: zoeTools.localTransfer error paths #9902

0xpatrickdev · 2024-08-15T21:42:33Z

closes: #9925
refs: #9193

Description

This PR primarily hardens the zoeTools implementation for orchestrated async-flows by:
- ensuring payments handled in zoeTools.localTransfer are recovered to the original seat in the event of failure or partial failure
- providing a zoeTools.withdrawFromSeat retriable function to facilitate withdrawing funds from a LocalChainAccount to a User seat. Ensures all changes are rolled back in the event of partial failure.
- using asVow instead of retriable since these operations are not idempotent
Creates src/fixtures/zoe-tools.contract.js to facilitate testing error paths
To facilitate the change, vowTools.allVowsSettled was implemented in @agoric/vow. See feat: vowTools.allSettled #10077 which this PR depends on

Security Considerations

Improves safety around Payment handling in async-flow contracts in @agoric/orchestration

Scaling Considerations

n/a

Documentation Considerations

Updates jsdoc strings for localTransfer and withdrawToSeat. As maintainer notes for considerations around asVow and promptness.

Testing Considerations

Includes tests with different failure paths previously unaccounted for.

Upgrade Considerations

Unreleased code that will be part of an npm release

cloudflare-workers-and-pages · 2024-08-15T21:45:40Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`ea73ef7`
Status:	✅ Deploy successful!
Preview URL:	https://cf7f029a.agoric-sdk.pages.dev
Branch Preview URL:	https://pc-send-anywhere-fixups.agoric-sdk.pages.dev

View logs

packages/orchestration/test/examples/sendAnywhere.test.ts

turadg

Good work. I've only done a quick reading pass. I'll come back for more thorough logic checking

packages/orchestration/src/examples/send-anywhere.flows.js

packages/orchestration/src/utils/zoe-tools.js

packages/orchestration/src/fixtures/zoe-tools.contract.js

turadg · 2024-09-12T17:39:09Z

packages/orchestration/src/utils/zoe-tools.js

+ paymentsKwr,
+ );
+ console.debug(depositResponse);
+ throw Fail`One or more deposits to LCA failed. ${q(errors)}`;


because Fail throws, I think we're developing some confusion by using throw Fail. WDYT of only using Fail for the check || Fail assertion pattern?

Suggested change

throw Fail`One or more deposits to LCA failed. ${q(errors)}`;

throw makeError`One or more deposits to LCA failed. ${q(errors)}`;

I am onboard! This makes things clearer.

Do you have a preference for makeError('One or more deposits to LCA failed. ${q(errors)}') vs makeError('One or more deposits to LCA failed', undefined, { errors }?

I've implemented the latter since that's what the interface was guiding towards. A draw back is that the nested error(s) only appears in logs.

I usually defer to @Chris-Hibbert on error elision

I think this is fine. I wouldn't expect the errors to reveal any sensitive details, and we believe we've returned the funds to the originator.

How does the end user become aware of the problem? Or if this is a tool for implementors to use, how can they detect the problem?

I'm beginning to think @turadg misdirected this question to me, and meant @kriskowal. I don't know much about makeError--that's deep inside endo.

we anticipate some level of error reporting in vstorage

that sounds very helpful.

I meant you @Chris-Hibbert because I recall your attention to redaction in Inter Protocol

I don't see a problem here.

I think that throw makeError is more theoretically sound, but throw Fail has the same effect (the throw is unreachable because Fail throws, that subsequent code is unreachable), and provides a more obvious, local indication that the following code is unreachable.

throw Fail has the same effect here but not always. I think we should avoid using throw Fail,

lint against throw Fail #10118

Chris-Hibbert

comments so far.

I may be away for an unknown period this afternoon, so sending what I have now.

Chris-Hibbert · 2024-09-12T18:02:09Z

packages/orchestration/src/fixtures/zoe-tools.contract.js

+ for (const chainName of ['agoric', 'cosmoshub']) {
+ chainHub.registerChain(chainName, fetchedChainInfo[chainName]);
+ }
+ for (const brand of values(zcf.getTerms().brands)) {


should this complain if no infos are found? Wouldn't it normally be a surprise if none were found? Maybe it would be helpful to return a count of the number that were found?

In a production-grade example, I agree this could be improved with more helpful messaging. But since this is just a test fixture, some checks to catch errors earlier are skipped.

consider a @file comment that this is not exemplary and takes shortcuts to support testing

Chris-Hibbert · 2024-09-12T18:17:57Z

packages/orchestration/src/utils/zoe-tools.js

@@ -63,21 +80,102 @@ export const makeZoeTools = (zone, { zcf, vowTools }) => {
 // );

 // Now all the `give` are accessible, so we can move them to the localAccount`
+ const payments = await Promise.all(
+ keys(give).map(kw => E(userSeat).getPayout(kw)),


There can be payouts that aren't in give. Where are those handled?

give is maybe a poor variable name - I didn't choose to rename it with these changes but can. give is a PaymentKeywordRecord so all payments should be accounted for.

I misspoke, it's an AmountKeywordRecrod not a PaymentKeywordRecord. What about amounts? Alternatively, we could use fromAmounts here and toAmounts for withdrawToSeat, mimicking atomicRearrange

There aren't two seats here, so amounts is fine.

AIUI, withdrawToSeat may have two seats, but the same amounts are transferred from and to, so amounts works there as well.

packages/orchestration/src/utils/zoe-tools.js

Chris-Hibbert · 2024-09-12T18:33:25Z

packages/orchestration/src/utils/zoe-tools.js

+ * `srcLocalAccount`. Supports multiple items in the `amounts`
+ * {@link PaymentKeywordRecord}.
+ */
+ const withdrawToSeat = retriable(


I'd like to see a test of this. (I didn't miss it, did I?)

There are a few in /test/utils/zoe-tools.test.ts:

'withdraw (withdrawToSeat) from LCA with insufficient balance'

'withdraw (withdrawToSeat) happy path'

'withdrawToSeat, unknown brand'

and near 'withdrawToSeat recovers from: simulated sendAll failure' in 'zoeTool.localTransfer error path' (withdrawSeat is used by localTransfer to recover)

oh, sorry. hidden by large diffs not rendered by default

packages/orchestration/src/utils/zoe-tools.js

Chris-Hibbert · 2024-09-12T19:05:51Z

packages/orchestration/test/examples/send-anywhere.test.ts

+ const amt = await E(zoe).getInvitationDetails(inv);
+ t.is(amt.description, 'send');
+
+ const anAmt = ist.make(SIMULATED_ERRORS.TIMEOUT);


That's distracting. There's nothing error-ish about this use, AFAICT. I'd prefer

Suggested change

const anAmt = ist.make(SIMULATED_ERRORS.TIMEOUT);

const arbitraryNat = 37n;

const anAmt = ist.make(arbitraryNat);

We've been using the SIMULATED_ERRORS constant to make it clear we are intentionally throwing an error in the test:

agoric-sdk/packages/vats/tools/fake-bridge.js

Lines 171 to 180 in 66e4cc0

/**

* Constants that can be used to force an error state in a bridge transaction.

* Typically used for the LocalChainBridge which currently accepts all messages

* unless specified otherwise. Less useful for the DibcBridge which rejects all

* messages unless specified otherwise.

*/

export const SIMULATED_ERRORS = {

TIMEOUT: 504n,

BAD_REQUEST: 400n,

};

The IBC bridge (used here) isn't trained to throw on these magic constants - it throws if it receives a message that doesn't have a handler registered via addMockAck. But the Localchain bridge is trained to do this, so I think consistently adopting this practice makes intentional errors clearer.

But the Localchain bridge is trained to do this,

It throws when it sees Amounts with these magic values? It can be difficult to inject errors, so I'll go along with this.

Yes, see fakeLocalChainBridgeTxMsgHandler:

agoric-sdk/packages/vats/tools/fake-bridge.js

Lines 193 to 228 in c1c5a6f

export const fakeLocalChainBridgeTxMsgHandler = (message, sequence) => {

switch (message['@type']) {

// TODO #9402 reference bank to ensure caller has tokens they are transferring

case '/ibc.applications.transfer.v1.MsgTransfer': {

if (message.token.amount === String(SIMULATED_ERRORS.TIMEOUT)) {

throw Error('simulated unexpected MsgTransfer packet timeout');

}

// like `JsonSafe<MsgTransferResponse>`, but bigints are converted to numbers

// FIXME should vlocalchain return a string instead of number for bigint?

return {

sequence,

};

}

case '/cosmos.bank.v1beta1.MsgSend': {

if (message.amount[0].amount === String(SIMULATED_ERRORS.BAD_REQUEST)) {

throw Error('simulated error');

}

return /** @type {JsonSafe<MsgSendResponse>} */ ({});

}

case '/cosmos.staking.v1beta1.MsgDelegate': {

if (message.amount.amount === String(SIMULATED_ERRORS.TIMEOUT)) {

throw Error('simulated packet timeout');

}

return /** @type {JsonSafe<MsgDelegateResponse>} */ ({});

}

case '/cosmos.staking.v1beta1.MsgUndelegate': {

return /** @type {JsonSafe<MsgUndelegateResponse>} */ ({

// 5 seconds from unix epoch

completionTime: { seconds: '5', nanos: 0 },

});

}

// returns one empty object per message unless specified

default:

return {};

}

};

It can be difficult to inject errors

+1

0xpatrickdev

Thanks @Chris-Hibbert ! I too will be afk and plan to revisit this tomorrow AM

0xpatrickdev · 2024-09-12T19:22:36Z

packages/orchestration/src/utils/zoe-tools.js

+ * `srcLocalAccount`. Supports multiple items in the `amounts`
+ * {@link PaymentKeywordRecord}.
+ */
+ const withdrawToSeat = retriable(


There are a few in /test/utils/zoe-tools.test.ts:

'withdraw (withdrawToSeat) from LCA with insufficient balance'

'withdraw (withdrawToSeat) happy path'

'withdrawToSeat, unknown brand'

and near 'withdrawToSeat recovers from: simulated sendAll failure' in 'zoeTool.localTransfer error path' (withdrawSeat is used by localTransfer to recover)

0xpatrickdev · 2024-09-12T19:29:46Z

packages/orchestration/test/examples/send-anywhere.test.ts

+ const amt = await E(zoe).getInvitationDetails(inv);
+ t.is(amt.description, 'send');
+
+ const anAmt = ist.make(SIMULATED_ERRORS.TIMEOUT);


We've been using the SIMULATED_ERRORS constant to make it clear we are intentionally throwing an error in the test:

agoric-sdk/packages/vats/tools/fake-bridge.js

Lines 171 to 180 in 66e4cc0

/**

* Constants that can be used to force an error state in a bridge transaction.

* Typically used for the LocalChainBridge which currently accepts all messages

* unless specified otherwise. Less useful for the DibcBridge which rejects all

* messages unless specified otherwise.

*/

export const SIMULATED_ERRORS = {

TIMEOUT: 504n,

BAD_REQUEST: 400n,

};

The IBC bridge (used here) isn't trained to throw on these magic constants - it throws if it receives a message that doesn't have a handler registered via addMockAck. But the Localchain bridge is trained to do this, so I think consistently adopting this practice makes intentional errors clearer.

packages/orchestration/src/utils/zoe-tools.js

0xpatrickdev · 2024-09-12T19:38:42Z

packages/orchestration/src/utils/zoe-tools.js

@@ -63,21 +80,102 @@ export const makeZoeTools = (zone, { zcf, vowTools }) => {
 // );

 // Now all the `give` are accessible, so we can move them to the localAccount`
+ const payments = await Promise.all(
+ keys(give).map(kw => E(userSeat).getPayout(kw)),


give is maybe a poor variable name - I didn't choose to rename it with these changes but can. give is a PaymentKeywordRecord so all payments should be accounted for.

packages/orchestration/src/utils/zoe-tools.js

0xpatrickdev · 2024-09-12T19:46:49Z

packages/orchestration/src/fixtures/zoe-tools.contract.js

+ for (const chainName of ['agoric', 'cosmoshub']) {
+ chainHub.registerChain(chainName, fetchedChainInfo[chainName]);
+ }
+ for (const brand of values(zcf.getTerms().brands)) {


In a production-grade example, I agree this could be improved with more helpful messaging. But since this is just a test fixture, some checks to catch errors earlier are skipped.

Chris-Hibbert

Thanks for letting me see this. I don't see anything objectionable. I'll leave it to others with more context to approve.

Chris-Hibbert · 2024-09-12T20:58:11Z

packages/orchestration/src/utils/zoe-tools.js

+ * `srcLocalAccount`. Supports multiple items in the `amounts`
+ * {@link PaymentKeywordRecord}.
+ */
+ const withdrawToSeat = retriable(


oh, sorry. hidden by large diffs not rendered by default

Chris-Hibbert · 2024-09-12T21:10:24Z

packages/orchestration/test/utils/zoe-tools.test.ts

+ }
+ }
+ t.log('withdrawToSeat recovers from: simulated sendAll failure ');
+ {


What's the benefit of putting multiple apparently separate tests into a single ava test run? The usual guideline is that independent tests should have separate test names, so their failures can be reported individually.

The usual exceptions are that execution must be in a particular order, or that setup is expensive. Neither seems to be the case here.

setup is expensive

This was the main reasoning, for the 6 nested conditions in this file I think it'd be an extra ~90 LOC. We haven't been diligent about enforcing 1 test assertion in 1 test run in this package, but usually use the optional 3rd message argument to help report the failure.

Chris-Hibbert · 2024-09-17T22:45:35Z

packages/orchestration/src/utils/zoe-tools.js

@@ -63,21 +80,102 @@ export const makeZoeTools = (zone, { zcf, vowTools }) => {
 // );

 // Now all the `give` are accessible, so we can move them to the localAccount`
+ const payments = await Promise.all(
+ keys(give).map(kw => E(userSeat).getPayout(kw)),


There aren't two seats here, so amounts is fine.

AIUI, withdrawToSeat may have two seats, but the same amounts are transferred from and to, so amounts works there as well.

Chris-Hibbert · 2024-09-17T22:56:47Z

packages/orchestration/src/utils/zoe-tools.js

 /**
- * Transfer the `give` a seat to a local account.
+ * Transfer the `give` of a seat to a local account. If any of the deposits


Suggested change

* Transfer the `give` of a seat to a local account. If any of the deposits

* Transfer the `give` amounts from srcSeat to localAccount. If any of the deposits

or after renaming,

Suggested change

* Transfer the `give` of a seat to a local account. If any of the deposits

* Transfer the amounts from srcSeat to localAccount. If any of the deposits

Chris-Hibbert · 2024-09-17T22:58:23Z

packages/orchestration/src/utils/zoe-tools.js

@@ -63,21 +80,106 @@ export const makeZoeTools = (zone, { zcf, vowTools }) => {
 // );

 // Now all the `give` are accessible, so we can move them to the localAccount`
+ const payments = await Promise.all(


update the comment above.

## Description - adds vowTools helper that mimics the behavior of `Promise.allSettled` to support #9902 - tests unstorable results path which resulted in a type guard change ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations Updates `vow/README.md` with information about `VowTools` ### Testing Considerations Includes unit tests ### Upgrade Considerations n/a, library code

github-actions · 2024-09-18T23:16:08Z

Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.

Chris-Hibbert · 2024-09-19T18:13:35Z

packages/orchestration/src/examples/send-anywhere.flows.js

+ );
+ } catch (e) {
+ await withdrawToSeat(contractState.localAccount, seat, give);
+ throw seat.fail(makeError(`IBC Transfer failed ${q(e)}`));


seat.fail() returns nothing. I see that our docs suggest this, but it doesn't make any sense to me.

I see the pattern in some of our example contracts, but not our production contracts.

What would you expect to see instead?

With:

seat.fail(makeError(`IBC Transfer failed ${q(e)}`)); return;

I see Promise resolved with undefined.

With only:

seat.fail(makeError(`IBC Transfer failed ${q(e)}`));

Execution continues and the seat.exit() a few lines down causes a rejection with Error: seat has been exited.

I'm using yarn test test/examples/send-anywhere.test.ts -m 'failed ibc transfer returns give' to hit this path.

Another option considered a while back was:

seat.exit(); throw makeError(`IBC Transfer failed ${q(e)}`)

but this seemed like an anti-pattern since seat.fail exists

I would have gone with

const errorMsg = `IBC Transfer failed ${q(e)}`; seat.exit(errorMsg); throw makeError(errorMsg);

Chris-Hibbert · 2024-09-19T18:19:09Z

packages/orchestration/src/utils/zoe-tools.js

 !srcSeat.hasExited() || Fail`The seat cannot have exited.`;
 const { zcfSeat: tempSeat, userSeat: userSeatP } = zcf.makeEmptySeatKit();
 const userSeat = await userSeatP;
- atomicTransfer(zcf, srcSeat, tempSeat, give);
+ atomicTransfer(zcf, srcSeat, tempSeat, amounts);


Suggested change

atomicTransfer(zcf, srcSeat, tempSeat, amounts);

zcf.atomicTransfer(srcSeat, tempSeat, amounts);

Please see c5ada2f

turadg · 2024-09-19T20:54:54Z

packages/orchestration/src/utils/zoe-tools.js

-/** @typedef {ReturnType<typeof makeZoeTools>} ZoeTools */
+
+/** @typedef {ReturnType<typeof makeZoeTools>} ZoeToolsHost */
+/** @typedef {GuestInterface<ZoeToolsHost>} ZoeTools */


are we always going to have the unqualified name be the guest? I don't recall if we've made that decision.

Consider not defining ZoeTools and letting the guest places use GuestInterface<ZoeToolsHost>

turadg · 2024-09-19T20:55:52Z

packages/orchestration/src/utils/zoe-tools.js

+export const makeZoeTools = (zcf, vowTools) => {
+ const { when, allVows, allSettled, asVow } = vowTools;


why delay the destructuring? It allows for a mixing of call styles in the same closure.

return asVow((

return vowTools.aVow(

packages/orchestration/src/utils/zoe-tools.js

turadg · 2024-09-19T20:59:16Z

packages/orchestration/src/utils/zoe-tools.js

- await null;
+ const withdrawToSeat = (localAccount, destSeat, amounts) =>
+ /*
+ * There are no interchain actions - everything happens on the local chain -


this explanation is helpful but strikes me as something to document and reference. (It's repeated twice here and surely there are other places equally worth noting it.)

Not a blocker for merge but something we should improve

Agree, moved to the @file declaration

- retriable that withdraws payments (described by an IssuerKeywordRecord) from a LCA to a user seat

- discussion: #9902 (comment)

- `retriable` does not seem to be a good fit for these functions as they are not idempotent

- discussion: #9902 (comment)

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch 2 times, most recently from f78755c to c537e65 Compare August 16, 2024 04:28

Base automatically changed from pc/send-anywhere-e2e to master August 16, 2024 12:13

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch from 7c43470 to e571565 Compare August 16, 2024 19:42

0xpatrickdev commented Aug 20, 2024

View reviewed changes

packages/orchestration/test/examples/sendAnywhere.test.ts Outdated Show resolved Hide resolved

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch 2 times, most recently from 08ac3f2 to 97c708a Compare August 27, 2024 18:19

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch from 97c708a to 7cec00d Compare September 10, 2024 22:19

0xpatrickdev changed the title ~~feat: sendAnywhere error paths~~ feat: zoeTools.localTransfer error paths Sep 11, 2024

0xpatrickdev mentioned this pull request Sep 12, 2024

feat: vowTools.allSettled #10077

Merged

0xpatrickdev changed the base branch from master to pc/all-vows-settled September 12, 2024 15:51

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch 2 times, most recently from ff9c7d0 to bf74f48 Compare September 12, 2024 15:56

0xpatrickdev force-pushed the pc/all-vows-settled branch from e1b5f2e to 891b473 Compare September 12, 2024 16:02

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch 2 times, most recently from 2ceca8a to e661353 Compare September 12, 2024 16:35

0xpatrickdev marked this pull request as ready for review September 12, 2024 17:01

0xpatrickdev requested review from turadg and Chris-Hibbert September 12, 2024 17:05

turadg reviewed Sep 12, 2024

View reviewed changes

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch from 3f568f1 to a33514c Compare September 12, 2024 19:01

Chris-Hibbert reviewed Sep 12, 2024

View reviewed changes

0xpatrickdev commented Sep 12, 2024

View reviewed changes

Chris-Hibbert reviewed Sep 12, 2024

View reviewed changes

0xpatrickdev force-pushed the pc/all-vows-settled branch 5 times, most recently from 82c4902 to 2bf7f89 Compare September 17, 2024 14:58

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch from 6273cb1 to 92821e9 Compare September 17, 2024 23:01

Chris-Hibbert reviewed Sep 17, 2024

View reviewed changes

0xpatrickdev force-pushed the pc/all-vows-settled branch 2 times, most recently from 947b150 to c3babe6 Compare September 18, 2024 22:42

Base automatically changed from pc/all-vows-settled to master September 18, 2024 23:15

feat: inspect fake bank bridge messages

d8a78d4

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch from 30a3f27 to 6a8aebc Compare September 19, 2024 00:26

0xpatrickdev added the force:integration Force integration tests to run on PR label Sep 19, 2024

0xpatrickdev requested a review from turadg September 19, 2024 00:31

0xpatrickdev marked this pull request as draft September 19, 2024 17:40

Chris-Hibbert reviewed Sep 19, 2024

View reviewed changes

0xpatrickdev marked this pull request as ready for review September 19, 2024 19:03

Chris-Hibbert approved these changes Sep 19, 2024

View reviewed changes

turadg reviewed Sep 19, 2024

View reviewed changes

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch from bb41c47 to 2cad888 Compare September 19, 2024 21:24

0xpatrickdev added 3 commits September 19, 2024 17:42

feat: zoeTools.withdrawToSeat

03a2b85

- retriable that withdraws payments (described by an IssuerKeywordRecord) from a LCA to a user seat

feat(sendAnywhere): handle failed IBC transfer

a90626a

feat: return failed transfer from contract localOrchAccount to seat

f09ce4a

0xpatrickdev added a commit that referenced this pull request Sep 19, 2024

refactor: prefer seat.exit() to seat.fail()

99f89dc

- discussion: #9902 (comment)

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch from 2cad888 to 99f89dc Compare September 19, 2024 21:44

0xpatrickdev added 2 commits September 19, 2024 17:46

feat: zoeTools uses asVow

41fbac0

- `retriable` does not seem to be a good fit for these functions as they are not idempotent

refactor: prefer seat.exit() to seat.fail()

ea73ef7

- discussion: #9902 (comment)

0xpatrickdev force-pushed the pc/send-anywhere-fixups branch from 99f89dc to ea73ef7 Compare September 19, 2024 21:46

0xpatrickdev requested a review from turadg September 19, 2024 21:48

turadg approved these changes Sep 19, 2024

View reviewed changes

0xpatrickdev added the automerge:rebase Automatically rebase updates, then merge label Sep 19, 2024

mergify bot merged commit 3e9ff43 into master Sep 19, 2024
86 of 94 checks passed

mergify bot deleted the pc/send-anywhere-fixups branch September 19, 2024 23:05

	throw Fail`One or more deposits to LCA failed. ${q(errors)}`;
	throw makeError`One or more deposits to LCA failed. ${q(errors)}`;

	const anAmt = ist.make(SIMULATED_ERRORS.TIMEOUT);
	const arbitraryNat = 37n;
	const anAmt = ist.make(arbitraryNat);

	/**
	* Constants that can be used to force an error state in a bridge transaction.
	* Typically used for the LocalChainBridge which currently accepts all messages
	* unless specified otherwise. Less useful for the DibcBridge which rejects all
	* messages unless specified otherwise.
	*/
	export const SIMULATED_ERRORS = {
	TIMEOUT: 504n,
	BAD_REQUEST: 400n,
	};

	export const fakeLocalChainBridgeTxMsgHandler = (message, sequence) => {
	switch (message['@type']) {
	// TODO #9402 reference bank to ensure caller has tokens they are transferring
	case '/ibc.applications.transfer.v1.MsgTransfer': {
	if (message.token.amount === String(SIMULATED_ERRORS.TIMEOUT)) {
	throw Error('simulated unexpected MsgTransfer packet timeout');
	}
	// like `JsonSafe<MsgTransferResponse>`, but bigints are converted to numbers
	// FIXME should vlocalchain return a string instead of number for bigint?
	return {
	sequence,
	};
	}
	case '/cosmos.bank.v1beta1.MsgSend': {
	if (message.amount[0].amount === String(SIMULATED_ERRORS.BAD_REQUEST)) {
	throw Error('simulated error');
	}
	return /** @type {JsonSafe<MsgSendResponse>} */ ({});
	}
	case '/cosmos.staking.v1beta1.MsgDelegate': {
	if (message.amount.amount === String(SIMULATED_ERRORS.TIMEOUT)) {
	throw Error('simulated packet timeout');
	}
	return /** @type {JsonSafe<MsgDelegateResponse>} */ ({});
	}
	case '/cosmos.staking.v1beta1.MsgUndelegate': {
	return /** @type {JsonSafe<MsgUndelegateResponse>} */ ({
	// 5 seconds from unix epoch
	completionTime: { seconds: '5', nanos: 0 },
	});
	}
	// returns one empty object per message unless specified
	default:
	return {};
	}
	};

	* Transfer the `give` of a seat to a local account. If any of the deposits
	* Transfer the `give` amounts from srcSeat to localAccount. If any of the deposits

	* Transfer the `give` of a seat to a local account. If any of the deposits
	* Transfer the amounts from srcSeat to localAccount. If any of the deposits

	atomicTransfer(zcf, srcSeat, tempSeat, amounts);
	zcf.atomicTransfer(srcSeat, tempSeat, amounts);

		export const makeZoeTools = (zcf, vowTools) => {
		const { when, allVows, allSettled, asVow } = vowTools;

feat: zoeTools.localTransfer error paths #9902

feat: zoeTools.localTransfer error paths #9902

Conversation

0xpatrickdev commented Aug 15, 2024 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages bot commented Aug 15, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

turadg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chris-Hibbert Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chris-Hibbert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turadg Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xpatrickdev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chris-Hibbert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 18, 2024

Choose a reason for hiding this comment

0xpatrickdev Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xpatrickdev commented Aug 15, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Aug 15, 2024 •

edited

Loading

Chris-Hibbert Sep 18, 2024 •

edited

Loading

turadg Sep 12, 2024 •

edited

Loading

0xpatrickdev Sep 19, 2024 •

edited

Loading