chore: make create-dapp compatible with yarn4
#9973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
e2d616d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://453eddf6.agoric-sdk.pages.dev |
| Branch Preview URL: | https://update-create-dapp-dep.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #XXXX
Description
As described in the issue linked above, currently, if a user has yarn4 and they run
yarn create @agoric/dapp demothe command fails because it uses pnp as the linker by default.The correct way to go about it imo is to properly document that if a user is using yarn4, they have to configure it to use
node-modulesas itsnodeLinker. This can either be done by creating a.yarnrc.ymlin the directory they are supposedly running theyarn createcommand, or by globally configuring it viayarn config set nodeLinker node-modulesbumping the agoric package is needed for yarn4 otherwise it throws an error
Security Considerations
Scaling Considerations
Documentation Considerations
Add a section on docs site while setting up yarn to properly configure nodeLinker
Testing Considerations
TODO: add CI step to test package download using different yarn versions via verdaccio
Upgrade Considerations