Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that compressed contract bundles are less than 1MB #36

Closed
0xpatrickdev opened this issue Jan 4, 2024 · 0 comments · Fixed by #56
Closed

Test that compressed contract bundles are less than 1MB #36

0xpatrickdev opened this issue Jan 4, 2024 · 0 comments · Fixed by #56
Assignees
@0xpatrickdev

Comments

@0xpatrickdev
Copy link
Member

The chain sdk has limitations on a tx message size - approx 1MB. See: Agoric/agoric-sdk#7501.

We should add a test that ensures compressed versions of the generated bundles do not exceed 1MB. Suggested: #34 (comment)

See here for an example of how to compress a bundle: https://github.com/DCFoundation/cosmos-proposal-builder/blob/84318e05322ed46653dbdd6634d0f9f1f304e180/src/lib/compression.ts#L27-L38

And here for a filepath for generated bundles from ci: https://github.com/Agoric/dapp-offer-up/actions/runs/7403614239/job/20143726617#step:6:24
@0xpatrickdev 0xpatrickdev mentioned this issue Jan 4, 2024
Merged
2 tasks
0xpatrickdev added a commit that referenced this issue Jan 24, 2024
@0xpatrickdev
test: ensure compressed bundle size is less than 1MB
95bfa8b 
closes #36
@0xpatrickdev 0xpatrickdev mentioned this issue Jan 24, 2024
Merged
@0xpatrickdev 0xpatrickdev self-assigned this Jan 24, 2024
0xpatrickdev added a commit that referenced this issue Jan 25, 2024
@0xpatrickdev
test: ensure compressed bundle size is less than 1MB
0e925c2 
closes #36
0xpatrickdev added a commit that referenced this issue Jan 25, 2024
@0xpatrickdev
test: ensure compressed bundle size is less than 1MB
4566b43 
closes #36
0xpatrickdev added a commit that referenced this issue Jan 25, 2024
@0xpatrickdev
test: ensure compressed bundle size is less than 1MB
5a3999f 
closes #36
@dckc dckc mentioned this issue Jan 31, 2024
Open
10 tasks
@dckc dckc mentioned this issue Aug 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xpatrickdev 0xpatrickdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: compressed bundle size is less than 1MB Agoric/dapp-offer-up
1 participant
@0xpatrickdev