Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Setting ENV from package.json #110

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Remove Setting ENV from package.json #110

merged 1 commit into from
Jan 8, 2025

Conversation

amessbee
Copy link
Contributor

@amessbee amessbee commented Jan 2, 2025

fixes #109

@amessbee amessbee force-pushed the ms/env-in-package.json branch from ee3a3ee to 02367ec Compare January 3, 2025 14:58
@amessbee amessbee marked this pull request as ready for review January 7, 2025 05:10
mujahidkay
mujahidkay reviewed Jan 7, 2025
View reviewed changes
ui/package.json Outdated Show resolved Hide resolved
@amessbee amessbee requested a review from mujahidkay January 8, 2025 08:16
mujahidkay
mujahidkay approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@mujahidkay mujahidkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Remember to remove the fixup commit via rebase before merging.

@amessbee @mujahidkay
fix: update env setting in ui/package.json
202c0e6 
Co-authored-by: Mujahid Khan <106528609+mujahidkay@users.noreply.github.com>
@amessbee amessbee force-pushed the ms/env-in-package.json branch from e9d2a65 to 202c0e6 Compare January 8, 2025 13:31
@amessbee amessbee merged commit a4bc68b into main Jan 8, 2025
3 checks passed
@amessbee amessbee deleted the ms/env-in-package.json branch January 8, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mujahidkay mujahidkay mujahidkay approved these changes

@Muneeb147 Muneeb147 Awaiting requested review from Muneeb147

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yarn 4 incompatibility: Env Variables in ui/package.json
2 participants
@amessbee @mujahidkay