Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve the description of build-game1-start.js #42

Merged
merged 1 commit into from
Jan 24, 2024
Merged

docs: Improve the description of build-game1-start.js #42

merged 1 commit into from
Jan 24, 2024

Conversation

gibson042
Copy link
Member

No description provided.

@gibson042 gibson042 requested a review from dckc January 10, 2024 16:00
@dckc
Copy link
Member

dckc commented Jan 11, 2024 •
edited
Loading

We're trying to get away from calling this a "game" (#18, #22). So I hesitate to dig the hole deeper.

In #38, I scrubbed "game" from many places, but I think I broke a bunch of stuff in the process. I aim to do it again, more carefully.

@dckc
Copy link
Member

dckc commented Jan 24, 2024

The rename and such (#45) has landed. Are you interested to pick this up again?
#49 added some docs... but only in the contract, I suppose.

Perhaps I should pick this up when I do...

@gibson042 gibson042 force-pushed the gibson-2024-01-proposal-build-docs branch from 9aea327 to 2b9dfe6 Compare January 24, 2024 16:43
@gibson042
Copy link
Member Author

@dckc Done and ready for review.

@gibson042 gibson042 merged commit 64f6e05 into main Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gibson042 @dckc