-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint devtools, clean-up #16
Changes from 6 commits
ab07bf9
e7a8598
e8b9c6f
634490f
930ee54
3dbe051
5a19ccc
13c9a49
ba16d53
5837732
e322251
509a23d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
## Uses .gitignore syntax and should mostly match that file | ||
## so that we don't format what never ends up in SCM. | ||
|
||
# artifacts | ||
build | ||
bundles | ||
bundle-*.js | ||
compiled | ||
dist | ||
lcov-report | ||
public |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
dist |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,34 +30,34 @@ | |
"@agoric/zone": "^0.2.2", | ||
"@cosmjs/amino": "^0.32.3", | ||
"@cosmjs/proto-signing": "^0.32.3", | ||
"@endo/eslint-plugin": "^0.5.2", | ||
"@endo/eslint-plugin": "^2.2.0", | ||
"@endo/nat": "^4.1.27", | ||
"@endo/promise-kit": "^0.2.56", | ||
"@endo/ses-ava": "^1.4.0", | ||
"@endo/ses-ava": "^1.2.4", | ||
Comment on lines
-36
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this bumps ses-ava down/back, right? I'm interested to know why. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1.2.4 is actually the latest version of https://www.npmjs.com/package/@endo/ses-ava |
||
"@jessie.js/eslint-plugin": "^0.4.0", | ||
"@rollup/plugin-commonjs": "^25.0.8", | ||
"@rollup/plugin-json": "^6.1.0", | ||
"@rollup/plugin-node-resolve": "^15.2.3", | ||
"@rollup/plugin-replace": "^5.0.5", | ||
"@rollup/plugin-typescript": "^11.1.6", | ||
"@typescript-eslint/eslint-plugin": "^6.7.0", | ||
"@typescript-eslint/parser": "^6.7.0", | ||
"@typescript-eslint/eslint-plugin": "^7.0.2", | ||
"@typescript-eslint/parser": "^7.15.0", | ||
"agoric": "^0.21.2-u12.0", | ||
"ava": "^5.3.1", | ||
"eslint": "^8.47.0", | ||
"eslint": "^8.57.0", | ||
"eslint-config-airbnb-base": "^15.0.0", | ||
"eslint-config-jessie": "^0.0.6", | ||
"eslint-config-prettier": "^9.0.0", | ||
"eslint-config-prettier": "^9.1.0", | ||
"eslint-plugin-ava": "^14.0.0", | ||
"eslint-plugin-github": "^4.10.0", | ||
"eslint-plugin-import": "^2.25.3", | ||
"eslint-plugin-jsdoc": "^46.4.3", | ||
"eslint-plugin-prettier": "^5.0.0", | ||
"eslint-plugin-import": "^2.29.1", | ||
"eslint-plugin-jsdoc": "^48.5.2", | ||
"eslint-plugin-prettier": "^5.1.3", | ||
"import-meta-resolve": "^2.2.1", | ||
"prettier-plugin-jsdoc": "^1.0.0", | ||
"rollup": "^4.18.0", | ||
"type-coverage": "^2.26.3", | ||
"typescript": "~5.2.2" | ||
"typescript": "^5.5.3" | ||
Comment on lines
-60
to
+59
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @turadg I had copied versions from agoric-sdk into Did you use any There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is your change. I don't recall changing this from your branch. It's the version in agoric-sdk |
||
}, | ||
"dependencies": { | ||
"@agoric/ertp": "dev", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,7 @@ export const installContract = async ( | |
* startArgs?: StartArgs; | ||
* issuerNames?: string[]; | ||
* }} opts | ||
* @param {object} [privateArgs] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried to get rid of this copy of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oic. I'll revise |
||
* | ||
* @typedef {Partial<Parameters<Awaited<BootstrapPowers['consume']['startUpgradable']>>[0]>} StartArgs | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still learning... how did you choose that version number? is it just the current in npm?
Did anything in particular prompt changing it? Should we generally recommend using the then-current versions of all lint-plugins in Agoric/agoric-sdk#8274 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this one I used
yarn upgrade-interactive