Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint devtools, clean-up #16

Merged
merged 12 commits into from
Aug 14, 2024
Merged

lint devtools, clean-up #16

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ab07bf9
chore(deps): devDependencies versions for lint etc.
dckc Aug 14, 2024
e7a8598
lint: prettierignore build output
turadg Aug 14, 2024
e8b9c6f
lint: ignore dist
turadg Aug 14, 2024
634490f
lint: document params
turadg Aug 14, 2024
930ee54
chore(deps): bump endo deps
turadg Aug 14, 2024
3dbe051
chore(deps): bump lint plugins
turadg Aug 14, 2024
5a19ccc
lint: typecheck
turadg Aug 14, 2024
13c9a49
fixup! lint: typecheck
turadg Aug 14, 2024
ba16d53
style: tsconfig default format
turadg Aug 14, 2024
5837732
build: remove obsolete patch-package
turadg Aug 14, 2024
e322251
fixup! style: tsconfig default format
turadg Aug 14, 2024
509a23d
fixup! build: remove obsolete patch-package
turadg Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
## Uses .gitignore syntax and should mostly match that file
## so that we don't format what never ends up in SCM.

# artifacts
build
bundles
bundle-*.js
compiled
dist
lcov-report
public
1 change: 1 addition & 0 deletions contract/.eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dist
20 changes: 10 additions & 10 deletions contract/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,34 +30,34 @@
"@agoric/zone": "^0.2.2",
"@cosmjs/amino": "^0.32.3",
"@cosmjs/proto-signing": "^0.32.3",
"@endo/eslint-plugin": "^0.5.2",
"@endo/eslint-plugin": "^2.2.0",
Comment on lines -33 to +32
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still learning... how did you choose that version number? is it just the current in npm?

Did anything in particular prompt changing it? Should we generally recommend using the then-current versions of all lint-plugins in Agoric/agoric-sdk#8274 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this one I used yarn upgrade-interactive

"@endo/nat": "^4.1.27",
"@endo/promise-kit": "^0.2.56",
"@endo/ses-ava": "^1.4.0",
"@endo/ses-ava": "^1.2.4",
Comment on lines -36 to +35
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bumps ses-ava down/back, right? I'm interested to know why.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.2.4 is actually the latest version of https://www.npmjs.com/package/@endo/ses-ava

"@jessie.js/eslint-plugin": "^0.4.0",
"@rollup/plugin-commonjs": "^25.0.8",
"@rollup/plugin-json": "^6.1.0",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-replace": "^5.0.5",
"@rollup/plugin-typescript": "^11.1.6",
"@typescript-eslint/eslint-plugin": "^6.7.0",
"@typescript-eslint/parser": "^6.7.0",
"@typescript-eslint/eslint-plugin": "^7.0.2",
"@typescript-eslint/parser": "^7.15.0",
"agoric": "^0.21.2-u12.0",
"ava": "^5.3.1",
"eslint": "^8.47.0",
"eslint": "^8.57.0",
"eslint-config-airbnb-base": "^15.0.0",
"eslint-config-jessie": "^0.0.6",
"eslint-config-prettier": "^9.0.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-ava": "^14.0.0",
"eslint-plugin-github": "^4.10.0",
"eslint-plugin-import": "^2.25.3",
"eslint-plugin-jsdoc": "^46.4.3",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsdoc": "^48.5.2",
"eslint-plugin-prettier": "^5.1.3",
"import-meta-resolve": "^2.2.1",
"prettier-plugin-jsdoc": "^1.0.0",
"rollup": "^4.18.0",
"type-coverage": "^2.26.3",
"typescript": "~5.2.2"
"typescript": "^5.5.3"
Comment on lines -60 to +59
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turadg I had copied versions from agoric-sdk into package.json; did you update typescript to "current from npm"?

Did you use any yarn upgrade ... tooling? or just edit package.json?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is your change. I don't recall changing this from your branch. It's the version in agoric-sdk

},
"dependencies": {
"@agoric/ertp": "dev",
Expand Down
1 change: 1 addition & 0 deletions contract/src/platform-goals/start-contract.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export const installContract = async (
* startArgs?: StartArgs;
* issuerNames?: string[];
* }} opts
* @param {object} [privateArgs]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to get rid of this copy of privateArgs. There's already a privateArgs in startArgs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oic. I'll revise

*
* @typedef {Partial<Parameters<Awaited<BootstrapPowers['consume']['startUpgradable']>>[0]>} StartArgs
*/
Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
"@endo/bundle-source": "2.5.2-upstream-rollup",
"@endo/captp": "^3.1.1",
"@endo/compartment-mapper": "^0.8.4",
"@endo/far": "^0.2.18",
"@endo/init": "^0.5.60",
"@endo/marshal": "^1.5.0",
"@endo/far": "^1.1.4",
"@endo/init": "^1.1.3",
"@endo/marshal": "^1.5.2",
"@endo/nat": "4.1.27",
"@endo/promise-kit": "^0.2.56",
"@endo/lockdown": "^0.1.28",
Expand All @@ -30,7 +30,6 @@
"@endo/stream": "^0.3.25",
"@endo/exo": "^0.2.2",
"@endo/check-bundle": "^0.2.18",
"@endo/ses-ava": "^0.2.40",
"@endo/netstring": "^0.3.26",
"@endo/stream-node": "^0.2.26",
"@noble/hashes": "github:paulmillr/noble-hashes#ae060daa6252f3ff2aa2f84e887de0aab491281d"
Expand All @@ -57,7 +56,8 @@
},
"devDependencies": {
"prettier": "^3.3.3",
"prettier-plugin-tailwindcss": "^0.5.11"
"prettier-plugin-tailwindcss": "^0.5.11",
"typescript": "^5.5.2"
},
"prettier": {
"trailingComma": "all",
Expand Down
2 changes: 1 addition & 1 deletion ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@types/react": "^18.2.56",
"@types/react-dom": "^18.2.19",
"@typescript-eslint/eslint-plugin": "^7.0.2",
"@typescript-eslint/parser": "^7.0.2",
"@typescript-eslint/parser": "^7.15.0",
"@vitejs/plugin-react": "^4.2.1",
"autoprefixer": "^10.4.17",
"eslint": "^8.56.0",
Expand Down
Loading