-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: e2e tests added for psm UI #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have suggestions later on the test writing style but I'd like to get this in now so we can get CI set up and see how the tests perform.
}); | ||
|
||
it('should swap tokens from IST to stable', () => { | ||
let ISTbalance; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our style is camel case
let ISTbalance; | |
let istBalance; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need to exclude tests/e2e
from vitest, I think we can do this by modifying vitest.config.ts like https://vitest.dev/config/#exclude
@samsiegart updated accordingly |
vitest.config.ts
Outdated
@@ -8,6 +8,10 @@ export default mergeConfig( | |||
test: { | |||
setupFiles: ['src/installSesLockdown.ts'], | |||
environment: 'happy-dom', | |||
exclude: [ | |||
...configDefaults.exclude, | |||
'tests/e2e/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternately we could consider tests
to be the purview of vitest and have synpress run in /integration-tests
or /e2e-tests
. I advise this to simplify the configurations but I defer to whatever @samsiegart prefers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if our goal is to simply config then just a head up: changing this path will require updating the synpress.config.js
file since it uses tests/e2e/**
as its default path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up, I think we can consider separating the directories but not a blocker
This PR aims to add e2e tests to the repo using the @agoric/synpress library. CI/CD setup to run these tests will be handled in a future PR
How to run and verify tests:
Note: Once the tests have been run a few times, you will need to recreate the docker container for the chain, since there will not be enough tokens to run the test again