Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI failure of e2e tests #151

Merged
merged 2 commits into from
Jun 14, 2024
Merged

fix CI failure of e2e tests #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55bdf51
chore: formatter run on file
frazarshad Jun 11, 2024
bde01c8
ci: prefer ipv4 resolution for e2e tests
rabi-siddique Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
phrase:
description: 'The mnemonic phrase for the account to use in testing'
required: false
type: text
type: string

concurrency:
group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label ||
Expand Down
6 changes: 6 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# syntax=docker/dockerfile:1
FROM --platform=linux/amd64 synthetixio/docker-e2e:18.16-ubuntu as base

# Recent e2e test failures for all dApps were due to inconsistent network configurations in the CI setup.
# GitHub Actions infrastructure can resolve localhost inconsistently (IPv4 or IPv6).
# To address this, we set NODE_OPTIONS=--dns-result-order=ipv4first to prioritize IPv4 DNS resolution.
# For more details, see: https://github.com/cypress-io/cypress/issues/27962
ENV NODE_OPTIONS=--dns-result-order=ipv4first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether there's a way to disable ipv6 for the whole Docker daemon. Node doesn't seem like the right level of abstraction for compatibility with the GH Action runner

Copy link
Contributor Author

@rabi-siddique rabi-siddique Jun 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we try this solution if you recommend it?

Also, we can pass the host flag to vite. This will allow the development server to accept connections from all network interfaces, and we won't need to disable IPv6 or set a priority for IPv4.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't any worse than the other options :) The link will help if someone is running into complexity it creates


RUN mkdir /app
WORKDIR /app

Expand Down
Loading