This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
fix: calculate debt correctly with interest #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
force-pushed
the
debt-with-interest
branch
from
db3d79d
to
2cf6d2c
Compare
turadg
reviewed
Apr 4, 2022
turadg
approved these changes
Apr 4, 2022
ui/src/components/VaultSummary.jsx
Outdated
Comment on lines
78
to
83
| /** | ||
| * @typedef {Object} Props | ||
| * @property {VaultData} vault | ||
| * @property {Object} brandToInfo | ||
| * @property {string} id | ||
| */ |
There was a problem hiding this comment.
just fyi, it might be less work to type:
Suggested change
| /** | |
| * @typedef {Object} Props | |
| * @property {VaultData} vault | |
| * @property {Object} brandToInfo | |
| * @property {string} id | |
| */ | |
| /** | |
| * @typedef {{ | |
| * vault: VaultData, | |
| * brandIToInfo: Object, | |
| * id: string, | |
| * }} Props | |
| */ |
That won't get auto-formatted until Agoric/agoric-sdk#4903
as an aside, is there a better type for brandToInfo?
There was a problem hiding this comment.
Ah yes much better. And yes just fixed that, good catch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #95