Skip to content

Swaparoo Contract - Added text explainer to go with video #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Swaparoo Contract - Added text explainer to go with video #1020

wants to merge 10 commits into from

Conversation

kbennett2000
Copy link
Contributor

@kbennett2000 kbennett2000 commented Mar 21, 2024 •
edited by dckc
Loading

closes #940

@kbennett2000 kbennett2000 requested a review from dckc March 21, 2024 15:56
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 21, 2024 •
edited
Loading

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: b4ddc7b
Status:🚫  Build failed.

View logs

@kbennett2000 kbennett2000 mentioned this pull request Mar 21, 2024
Open
dckc
dckc previously requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one important change

also, for approval, I'm inclined to defer to @sufyaankhan

@dckc
Copy link
Member

dckc commented Mar 21, 2024

oh... also... do we want to keep https://docs.agoric.com/guides/zoe/contracts/atomic-swap.html ? if so, we should have links in both directions

Base automatically changed from kbennett2000-patch-5 to main March 21, 2024 22:23
@kbennett2000
Copy link
Contributor Author

Closes #940

@kbennett2000 @dckc
Update main/guides/getting-started/swaparoo-how-to-swap-assets-explai…
bbf8ab8 
…ner.md

Co-authored-by: Dan Connolly <connolly@agoric.com>
@kbennett2000
Copy link
Contributor Author

oh... also... do we want to keep https://docs.agoric.com/guides/zoe/contracts/atomic-swap.html ? if so, we should have links in both directions

I'll defer to @sufyaankhan on that one...

@dckc
Copy link
Member

dckc commented Mar 26, 2024

Closes #940

I think it has to go in the description... let's see...

in the pull request's description or in a commit message
-- Linking a pull request to an issue using a keyword

@dckc dckc dismissed their stale review March 26, 2024 15:02

requested change made

@kbennett2000 kbennett2000 changed the title Swaparoo Contract - Added text explainer to go with video Swaparoo Contract - Added text explainer to go with video - closes #940 Mar 29, 2024
@kbennett2000 kbennett2000 requested a review from dckc March 29, 2024 14:14
dckc
dckc requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is a new page, it needs to be referenced in nav.js and/or config.mjs

@kbennett2000 kbennett2000 changed the title Swaparoo Contract - Added text explainer to go with video - closes #940 Swaparoo Contract - Added text explainer to go with video Mar 29, 2024
@kbennett2000
Copy link
Contributor Author

since this is a new page, it needs to be referenced in nav.js and/or config.mjs

@sufyaankhan - did we decide where in the navigation these explainers are going to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc requested changes

@sufyaankhan sufyaankhan Awaiting requested review from sufyaankhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page 2 - How to Swap assets
2 participants
@kbennett2000 @dckc