-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer Service updates #1024
Timer Service updates #1024
Conversation
|
The preview is not yet generating, but when this was part of #1022, I could see that there were gaps in the doc this is generated from. I'd like to fill in some of that. How did you build this? What do I have to do to correct the source material? Is this generated purely from |
Yes. |
|
1 similar comment
|
f78b8b6
to
d5e8189
Compare
Deploying documentation with Cloudflare Pages
|
for reference...
with ~/projects/agoric-sdk$ yarn add -W -D typedoc typedoc-plugin-markdown diff --git a/typedoc.json b/typedoc.json
index 685abaab4..061bccfaa 100644
--- a/typedoc.json
+++ b/typedoc.json
@@ -7,6 +7,7 @@
],
"name": "API documentation of Agoric SDK ",
"entryPointStrategy": "packages",
+ "plugin": ["typedoc-plugin-markdown"],
"out": "api-docs",
"includeVersion": true,
"logLevel": "Verbose" ~/projects/agoric-sdk$ yarn typedoc
...
~/projects/agoric-sdk$ tar cf ~/time.tar api-docs/modules/agoric_time.md api-docs/interfaces/agoric_time.* then in this repo: ~/projects/documentation/main tar xf ~/time.tar |
Ahh. Thanks. I didn't know about specifying plugins in typedoc.json, but I was able to get a .html version so I could see what was generated. I hope there isn't a huge difference. |
@LuqiPan can you tell why https://docs.agoric.com/reference/agoric-sdk/modules/agoric_time is missing TimerService etc? This PR should be largely obsolete as of #1038 , but the above page is missing a lot of stuff that this PR produces: https://dc-timer-ref.documentation-7tp.pages.dev/api-docs/modules/agoric_time.html |
Pull request was converted to draft
These are the relevant logs for time package when building on CF:
These are the logs when building on agoric-sdk/master:
Looks pretty similar. Is TypeScript 5.5.0 affecting things? |
TypeScript 5.4.3 still yielded similar results:
@dckc did you remember roughly with what git hash you built the |
I think I used based on notes in Agoric/agoric-sdk#9131 It's strange... the "Defined in" links to to, for example, https://github.com/Agoric/agoric-sdk/blob/b78dc2aa5/packages/time/src/types.d.ts#L174 but that's 404. as is Agoric/agoric-sdk@b78dc2aa5 I don't seem to have that one locally either. |
Cloudflare deployment logs are available here |
PTAL. |
closes #948
replaces time-related reference docs with a link to https://agoric-sdk.pages.dev/modules/_agoric_time
rendered: