Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UIComponentsstart.md #1077

Merged
merged 1 commit into from
May 7, 2024
Merged

Create UIComponentsstart.md #1077

merged 1 commit into from
May 7, 2024

Conversation

otoole-brendan
Copy link
Contributor

@kbennett2000 this is me re-attempting to create new folder at the 'Getting Started' hierarchy

Copy link
Contributor

@kbennett2000 kbennett2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@otoole-brendan otoole-brendan merged commit 50303cf into main May 7, 2024
2 of 4 checks passed
@otoole-brendan otoole-brendan deleted the otoole-brendan-patch-1 branch May 7, 2024 18:51
Copy link
Member

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this PR appears to have broken the build: https://github.com/Agoric/documentation/runs/24697106620


## Installation and Setup

See [Introduction to Agoric UI Kit](https://a0a31cba.documentation-7tp.pages.dev/guides/getting-started/how-to-use-ui-kit#introduction-to-agoric-ui-kit) for installation and setup how-to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably shouldn't link to a CI rendering.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite:

use relative links instead of absolute ones for any links to files or folders in the Documentation repo
-- [Writing Links in CONTRIBUTING]

|----------|----------|----------|
| value | bigint | null | The current value of the input |
| decimalPlace | number | The number of decimal places used for displaying the denominated value |
| className | string | undefined | CSS class name for the underlying <input> element |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| className | string | undefined | CSS class name for the underlying <input> element |
| className | string | undefined | CSS class name for the underlying \<input> element |

Customizable Parameters
| Parameter | Type | Description |
|----------|----------|----------|
| ClassName | string | CSS class name for the underlying <button> element |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| ClassName | string | CSS class name for the underlying <button> element |
| ClassName | string | CSS class name for the underlying \<button> element |


<img style="border: 2px solid grey"
alt="Screenshot: Connect Wallet"
src="./assets/connectwallet.png" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RollupError: Could not resolve "./assets/connectwallet.png" from "main/guides/UIComponentLibrary/UIComponentsstart.md"

The assets directory is one level up, but does not contain a connectwallet.png file. Maybe it should be this?

Suggested change
src="./assets/connectwallet.png" />
src="../assets/5-ConnectWalletUI.png" />

(and likewise for the other <img>s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants