fix: awaitify current amounts #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK to me, but there are other places in the docs that will need updates. I've added myself as a reviewer on Agoric/agoric-sdk#2109 so I'll know when it's checked in and can go make the needed corrections. |
|
@tyg is this an approval? Am I clear to merge? |
|
Please don't merge yet. I'll add in the other changes as discussed on Keybase, and then Kate can do an approval when the agoric-sdk#2109 merge happens. |
Co-authored-by: Kate Sills <kate@agoric.com>
|
Thanks for your patience @tyg. I am closing as we have decided not to move forward with the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for Agoric/agoric-sdk#2109 by awaiting the results of the (soon to be deprecated)
getCurrentAmount. After 2109 is merged, a later PR should update this to saygetRecentAmountinstead.