docs: name services: agoricNames, namesByAddress, board (WIP) #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
commented
Jan 9, 2024
| const { instance } = await E(zoe).startInstance(myNewContract); | ||
| const { brands: { Thing: thingBrand } } = await E(zoe).getTerms(instance); | ||
| const brandAdmin = E(agoricNamesAdmin).lookupAdmin('brand'); | ||
| await E(brandAdmin).update('Thing', thingBrand); |
There was a problem hiding this comment.
This is a bad example. BLD staker governance should not approve meaningless names such as Thing.
There was a problem hiding this comment.
Also TODO: note the risk of registering under a name such as BTC a brand for an asset that I just made up and that the market will not value at 1 BTC.
dckc
commented
Jan 9, 2024
| The keys of `agoricNames` include: | ||
| - `brand` - IST, BLD, Invitation (Zoe invitation brand), timer (a TimerBrand, not an ERTP brand) | ||
| - `issuer` - IST, BLD, Invitation, ... | ||
| - `vbankAsset` - IST, BLD, USDC, ATOM, ... - including info about corresponding cosmos denom |
There was a problem hiding this comment.
TODO: give the type of the values of the vbankAsset namehub
There was a problem hiding this comment.
kbennett2000
approved these changes
Jan 11, 2024
dckc
commented
Jan 16, 2024
Comment on lines
+64
to
+69
| ```js | ||
| const bobAddress = 'agoric1...'; | ||
| const anInvitationPayment = await zcf.makeInvitation(...); | ||
| const bobDepositFacet = E(namesByAddress).lookup(bobAddress, 'depositFacet'); | ||
| const amtReceived = await E(bobDepositFacet).receive(anInvitationPayment); | ||
| ``` |
There was a problem hiding this comment.
ideally, these would be tested snippets of an example dapp
But dapp-offer-up doesn't use namesByAddress.
dckc
commented
Jan 16, 2024
dckc
commented
Jan 16, 2024
dckc
commented
Jan 16, 2024
dckc
commented
Jan 16, 2024
Deploying with
|
| Latest commit: |
472ebe7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad34e637.documentation-7tp.pages.dev |
| Branch Preview URL: | https://dc-name-services.documentation-7tp.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #807
DRAFT until
integrations/is a reasonable place to put this)stretch goals: