build: update dependencies to match dapp-offer-up (agoric-upgrade-13) #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add endo resolutions to avoid aliases - treat packages we're documenting (ertp etc.) as dependencies, not devDependencies - hm. bundle-source too? - not vats; it's only for fake board - also update dev tools: tsc, ava, prettier to match dapp-offer-up - typescript from dep to devdep
- disable test-no-ses password exfiltration test
no longer available as @agoric/zoe/test/unitTests/setupBasicMints.js copied from ff9515b
not packaged as @agoric/zoe/test/zoeTestHelpers.js
dckc
force-pushed
the
dc-test-preamble
branch
from
ff2c5a6
to
d43b526
Compare
Deploying with
|
| Latest commit: |
10284bb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4a407e3.documentation-7tp.pages.dev |
| Branch Preview URL: | https://dc-test-preamble.documentation-7tp.pages.dev |
turadg
reviewed
Feb 6, 2024
There was a problem hiding this comment.
I see the fix for #843 but I wonder why this is trying to deduplicate bundle IDs when documentation doesn't ship to a chain.
Hard-coding the resolutions version numbers is causing other problems,
warning Resolution field "@babel/code-frame@7.18.6" is incompatible with requested version "@babel/code-frame@^7.23.5"
warning Resolution field "@babel/code-frame@7.18.6" is incompatible with requested version "@babel/code-frame@^7.23.5"
warning Resolution field "@endo/eventual-send@0.17.2" is incompatible with requested version "@endo/eventual-send@^0.17.6"
warning Resolution field "@endo/pass-style@0.1.3" is incompatible with requested version "@endo/pass-style@^0.1.7"
warning Resolution field "@endo/eventual-send@0.17.2" is incompatible with requested version "@endo/eventual-send@^0.17.6"
warning Resolution field "@endo/nat@4.1.27" is incompatible with requested version "@endo/nat@^4.1.31"
warning Resolution field "@endo/pass-style@0.1.3" is incompatible with requested version "@endo/pass-style@^0.1.7"
warning Resolution field "@endo/promise-kit@0.2.56" is incompatible with requested version "@endo/promise-kit@^0.2.60"
warning Resolution field "ses@0.18.5" is incompatible with requested version "ses@^0.18.8"
warning Resolution field "@babel/code-frame@7.18.6" is incompatible with requested version "@babel/code-frame@^7.23.5"
warning Resolution field "@babel/code-frame@7.18.6" is incompatible with requested version "@babel/code-frame@^7.23.5"
warning Resolution field "@babel/code-frame@7.18.6" is incompatible with requested version "@babel/code-frame@^7.23.5"
warning Resolution field "@babel/code-frame@7.18.6" is incompatible with requested version "@babel/code-frame@^7.23.5"
There's also this major version incompatibility, which seems to be the cause of the CI failure:
warning " > @typescript-eslint/parser@4.33.0" has incorrect peer dependency "eslint@^5.0.0 || ^6.0.0 || ^7.0.0".
- reformatting following @Agoric style - make sure 1st await is not nested - Compartment global is already declared - use createRequire from node stdlib rather than import-meta-resolve - allow devDependencies to satisfy makeFakeBoard - avoid @agoric/assert dependency
I'd like tests and such to behave the same here as in dapp-offer-up. But |
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #843
includes the resolutions work-around for