feat(zoe): describe afterDeadline functionality in more detail #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
0xpatrickdev
commented
Feb 8, 2024
0xpatrickdev
commented
- replaces feat(afterDeadline): ensure it's clear the seat is not exitable by a user before the deadline #821 (branch exists on a personal remote)
dckc
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
I expect the outcome of Agoric/agoric-sdk#4291 to be that these API reference docs are generated from JSDoc in agoric-sdk.
But meanwhile, I suppose this doesn't hurt much.
| A contract can enforce a certain proposal shape using the | ||
| **[M](https://endojs.github.io/endo/interfaces/_endo_patterns.PatternMatchers.html)** (for '**M**atcher') object from `@endo/patterns`. | ||
|
|
||
| For example, a contract holding an auction might require that all offers include an `afterDeadline` exit rule with a timestamp in the future. |
There was a problem hiding this comment.
Show the example? In particular: show / explain that zcf.makeInvitation() is the way to actually do it.
kbennett2000
approved these changes
Feb 9, 2024
0xpatrickdev
force-pushed
the
pc/zoe-offers-after-deadline
branch
from
3ee7e04
to
ba795c6
Compare
Deploying with
|
| Latest commit: |
ba795c6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c6c37b5.documentation-7tp.pages.dev |
| Branch Preview URL: | https://pc-zoe-offers-after-deadline.documentation-7tp.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.