ngx-material-timepicker-285 24hr format, invalid dateTime #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobszarny
commented
Feb 27, 2020
tobszarny
commented
- made TimeAdapter.formatTime respect given locales
* made TimeAdapter.formatTime respect given locales
sebsrt
approved these changes
Feb 28, 2020
|
Pls fix tests, they fails on CI |
Agranom
reviewed
Feb 29, 2020
|
|
||
| return TimeAdapter.parseTime(time, opts).setLocale(TimeAdapter.DEFAULT_LOCALE) | ||
| return TimeAdapter.parseTime(time, opts).setLocale(locale ? locale : TimeAdapter.DEFAULT_LOCALE) |
There was a problem hiding this comment.
you can simplify to locale || TimeAdapter.DEFAULT_LOCALE
|
Sorry, but I didn't get which bug this PR is supposed to fix? |
|
It was a fix for 24 hour format Invalid DateTime for 00:00 to 00:59 |
|
Btw, have any CI where I can check which tests are failing? |
|
Never mind. Found Travis link on your home page. Will see into that. Curiously enough the tests are passing on my machine. So there still seems to be some platform dependence when it comes to locales. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.