Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timepicker-face quarter detection (#324). #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix timepicker-face quarter detection (#324). #357

wants to merge 1 commit into from

Conversation

anton-nikiforenko
Copy link

No description provided.

@tonysamperi
Copy link

@nikiforenkoanton could you explain where exactly the benefit is?

@anton-nikiforenko
Copy link
Author

@tonysamperi the benefit is that you will not select incorrect time, by clicking on the correct button, in some rare cases :)
E.g., you could try to select 9:45am but timepicker will select 3:15am. I have noticed this behaviour far ago, but was thinking that this was my misclicks or I have done it inattentionally. I haven't receive any complaints from the users about this bug yet, but this could be due to timepicker is not used frequently.
This bug was detected after some E2E tests have beeen written, because all E2E frameworks are clicking in the actual center of html element. And some workarounds were required to bypass this issue in the E2E-tests.

Repository owner deleted a comment from tonysamperi Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-nikiforenko @tonysamperi