forked from stellar/stellar-cli
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: CI test bindings typescript
-generated libs
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
force-pushed
the
build/test-generated-libs
branch
from
August 22, 2023 18:14
dcc423d
to
41e35f0
Compare
chadoh
force-pushed
the
build/test-generated-libs
branch
from
August 22, 2023 20:15
732d03f
to
533544d
Compare
chadoh
force-pushed
the
build/test-generated-libs
branch
from
August 23, 2023 15:43
d28fe3e
to
9b843fb
Compare
* fix: update bindings to use new soroban-client and ContractSpec class * chore: remove yarn.lock * Need to enable base64 in stellar-xdr --------- Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
willemneal
force-pushed
the
build/test-generated-libs
branch
from
August 23, 2023 16:45
0d982d6
to
7d72e5b
Compare
Was a temp try to get cargo run to work, but isn't needed any more
willemneal
added a commit
that referenced
this pull request
Aug 25, 2023
* build: add bindings-ts github workflow * fix: update bindings to use new soroban-client and ContractSpec class * Need to enable base64 in stellar-xdr --------- Co-authored-by: Willem Wyndham <willem@ahalabs.dev> * feat(CLI): add dotenv so directories can now set CLI args * fix: don't fail if wasm already exists and log associated error as debug * fix: update to use use .env and store standalone in local config * fix: add standalone * fix: return to src Was a temp try to get cargo run to work, but isn't needed any more * build: test generated lib for test-wasms/hello_world * build: add auth test * build: add signing to test wallet * fix: parse returnValue * build: update comment and typecheck * rust: appease clippy and fmt with after new Rust release (stellar#899) * fix: update soroban-client --------- Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
chadoh
added a commit
that referenced
this pull request
Oct 9, 2023
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.
chadoh
added a commit
that referenced
this pull request
Oct 19, 2023
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.
chadoh
added a commit
to stellar/stellar-cli
that referenced
this pull request
Nov 20, 2023
Add tests from AhaLabs#11 which didn't make it into #973 due to the quickstart image not starting properly in CI. Adding this directly to #973 was costing too much time. We can troubleshoot quickstart issues here.
chadoh
added a commit
that referenced
this pull request
Nov 20, 2023
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.
chadoh
added a commit
that referenced
this pull request
Jan 5, 2024
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.
chadoh
added a commit
that referenced
this pull request
Jan 5, 2024
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.
chadoh
added a commit
that referenced
this pull request
Jan 11, 2024
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.
chadoh
added a commit
that referenced
this pull request
Jan 11, 2024
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here. Update for latest changes from `soroban config identity` to `soroban keys`
chadoh
added a commit
that referenced
this pull request
Jan 11, 2024
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here. Update for latest changes from `soroban config identity` to `soroban keys`
chadoh
added a commit
that referenced
this pull request
Jan 11, 2024
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here. Update for latest changes from `soroban config identity` to `soroban keys`
chadoh
added a commit
that referenced
this pull request
Jan 11, 2024
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here. Update for latest changes from `soroban config identity` to `soroban keys`
chadoh
added a commit
that referenced
this pull request
Jan 11, 2024
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here. Update for latest changes from `soroban config identity` to `soroban keys`
chadoh
added a commit
that referenced
this pull request
Jan 11, 2024
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here. Update for latest changes from `soroban config identity` to `soroban keys`
chadoh
added a commit
that referenced
this pull request
Jan 12, 2024
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI. Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here. Update for latest changes from `soroban config identity` to `soroban keys`
Shaptic
pushed a commit
to stellar/stellar-cli
that referenced
this pull request
Jan 12, 2024
* Add tests from AhaLabs#11 which didn't make it into #973 due to the quickstart image not starting properly in CI. * Update for latest changes from `soroban config identity` to `soroban keys`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add CI test to run the tests in cmd/crates/soroban-spec-typescript/ts-tests
Why
This will ensure that the generated typescript libraries continue to work as they should.
Known limitations
You can see that right now this workflow needs to install soroban-cli 0.9.4 rather than the one from the repo itself. This is because the repo itself is currently broken with the quickstart Docker image. Once we start keeping
main
in a working state with quickstart, we can fix this.