feat(bindings-ts): support multi-auth workflows #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
force-pushed
the
feat/bindings-ts/multi-auth
branch
from
7919dbf to
888bdb7
Compare
chadoh
force-pushed
the
chore/bindings_udate
branch
from
ba4ecf9 to
bff2f5c
Compare
chadoh
force-pushed
the
feat/bindings-ts/multi-auth
branch
from
888bdb7 to
a578558
Compare
chadoh
force-pushed
the
chore/bindings_udate
branch
from
bff2f5c to
486fca1
Compare
chadoh
force-pushed
the
feat/bindings-ts/multi-auth
branch
2 times, most recently
from
b27ea0b to
cbab0be
Compare
chadoh
force-pushed
the
chore/bindings_udate
branch
from
486fca1 to
779f04c
Compare
chadoh
force-pushed
the
feat/bindings-ts/multi-auth
branch
from
cbab0be to
6cf1866
Compare
* chore: update ts bindings What ---- Update the typescript bindings with all the changes that landed in the futurenet-compatible `smartdeploy` branch since `main` stopped working with futurenet. Why --- Lots of good improvements and fixes are not yet in `main`, ~including tests for the generated libraries.~ _CI tests will be included in a future PR; reasonable time-sink exceeded for this one. Closes: stellar#996 Known limitations ----------------- The newly-added tests are not yet being exercised in CI; you can see the commit history for all the details of how we tried to work around this. At this point, we will: - wait for stellar/quickstart#507 to get merged & included in a published quickstart image - retry the `bindings-ts.yml` workflow, which was almost working except that friendbot was not starting properly when quickstart was run _in CI_ (though it does start properly, even if a bit slowly, when quickstart is run locally) - after a basic run-tests-with-published-quickstart is working, the next step is to build a custom quickstart image using _this repository's_ RPC version, and use that custom quickstart to run the integration tests. This might be able to be accomplished [as described by ChatGPT here](https://chat.openai.com/share/0f355fbe-93b9-4c8d-9c12-7f54846134bd). * build: bump delta for flaky test * build: increase deltas in cli simulation test --------- Co-authored-by: Willem Wyndham <willem@ahalabs.dev> Co-authored-by: Tsachi Herman <24438559+tsachiherman@users.noreply.github.com>
* update. * preserve cors behaviour * update version
* feat!: remove run_in_sandbox * fix: reorganize tests that rely on network and ignore outside of go test * fix: use feature instead of cfg so that cargo test --list can find tests * fix: move common tests to single functions to skip setup time * feat!: skip wasm in invoke * fix: fully remove all sandbox related types and args
chadoh
force-pushed
the
feat/bindings-ts/multi-auth
branch
from
6cf1866 to
73a9b60
Compare
- add `atomic_swap` and `token` contracts from https://github.com/stellar/soroban-examples to `test-wasms` - greatly complicate `ts-tests/package.json` to deploy & generate bindings for these new contracts, plus creating an `alice` identity and minting separate amounts of two separate tokens to the `root` user and `alice` - add tests for atomic swap functionality inspired by https://github.com/stellar/soroban-react-atomic-swap - let this logic guide needed updates to `bindings typescript`-generated libraries: - don't return flat values - instead, always return an object which will have at least a `txUnsigned` and `simulation` key - object contains all possibly-relevant fields from the logic it performs Co-authored-by: Aristides Staffieri <aristides.staffieri@stellar.org>
chadoh
force-pushed
the
feat/bindings-ts/multi-auth
branch
from
73a9b60 to
d37d503
Compare
|
Closing in favor of stellar#1034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atomic_swapandtokencontracts fromhttps://github.com/stellar/soroban-examples to
test-wasmsts-tests/package.jsonto deploy & generatebindings for these new contracts, plus creating an
aliceidentityand minting separate amounts of two separate tokens to the
rootuserand
alicehttps://github.com/stellar/soroban-react-atomic-swap
bindings typescript-generatedlibraries:
txUnsignedandsimulationkeyperforms