add TS demo that attempts to get invoke types correct #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you check the inferred return types for the examples in `figuring-out-types.ts`, you'll see that the ones that leave `options` totally undefined/empty for `invoke` return an intersection type (`string | "sim" | "rpc"`), rather than the correct `T` (ie `string`).
something about the presence of T but _not_ R seems to really trip up the type inference
chadoh
force-pushed
the
docs/figuring-out-types
branch
from
a96f40b
to
b514667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
For stellar#753, I want to make sure that
invokeand all the auto-generated functions inindex.tsactually return correct types. This adds a self-containedfiguring-out-types.tsfile that demonstrates that this hasn't been figured out yet.Why
People will use these functions all the time, and probably mostly in their most simple form.
balance({ address: 'GAAA…' }), I want my editor to know that it's abigint.balance({ address: 'GAAA…', responseType: 'simulated' }), I want my editor to know that it's aSorobanClient.SorobanRpc.SimulationResponseType.So far, I've been able to get the types to return correctly if you explicitly set
responseType, but not for the simplest, most common call type.Known limitations
[TODO or N/A]