67: Use XCTContext runActivityNamed:block: to insert the step's title in the report #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll get to this after the 4th of July. Busy at work and then a small vacation. |
brentleyjones
requested changes
Jul 17, 2017
| if (xctContextClass) { | ||
| SEL aSelector = NSSelectorFromString(@"runActivityNamed:block:"); | ||
|
|
||
| id block = ^(id activity) { |
There was a problem hiding this comment.
You an pull out this block before the check and then execute it in the else case. That way if we need to change what it does we only change it in one spot. Also, it makes the if case have a single responsibility of wrapping the activity.
There was a problem hiding this comment.
Good idea. Done
brentleyjones
approved these changes
Jul 18, 2017
|
Thanks @TitouanVanBelle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to answer issue #67's needs and adds step titles in the report. It uses Xcode 9's new class XCTContext and therefore doesn't work on Xcode 9.
Here's how it looks on Xcode 9
Here's how it looks on Xcode 8
Let me know what you think