Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): rename maxMachine to maxMachineId. #629

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

Ahoo-Wang
Copy link
Owner

No description provided.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.39%. Comparing base (cca284c) to head (70943cc).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...a/me/ahoo/cosid/snowflake/AbstractSnowflakeId.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #629      +/-   ##
============================================
+ Coverage     84.34%   84.39%   +0.04%     
- Complexity     1281     1282       +1     
============================================
  Files           210      210              
  Lines          4165     4165              
  Branches        421      421              
============================================
+ Hits           3513     3515       +2     
+ Misses          368      367       -1     
+ Partials        284      283       -1     
Flag Coverage Δ
unittests 84.39% <83.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ahoo-Wang Ahoo-Wang merged commit c5ab07b into main Sep 12, 2024
40 of 41 checks passed
@Ahoo-Wang Ahoo-Wang deleted the SnowflakeId branch September 12, 2024 02:16
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant