Skip to content

Commit

Permalink
Merge pull request #286 from pvds/feature/migrate-to-angular-17
Browse files Browse the repository at this point in the history
Feature/migrate to angular 17
  • Loading branch information
AhsanAyaz authored Nov 20, 2023
2 parents dcc5a00 + 7747461 commit 934c448
Show file tree
Hide file tree
Showing 22 changed files with 6,429 additions and 5,685 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.4
- name: Use Node.js 12.8
- name: Use Node.js
uses: actions/setup-node@v2
with:
node-version: '14'
node-version: '18'
- name: Install dependencies
run: npm install
- name: Lint and Test
Expand Down
9 changes: 9 additions & 0 deletions CHANGE_LOG.MD
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
# [7.0.0](https://github.com/AhsanAyaz/ngx-device-detector/compare/v6.0.2...v7.0.0) (2023-11-16)


### Features

* **v17:** migrate to v17 ([70f3f53](https://github.com/AhsanAyaz/ngx-device-detector/commit/70f3f53d1cefb9bfde2fd06ee21140e8ec98f22d))



## [6.0.2](https://github.com/AhsanAyaz/ngx-device-detector/compare/v6.0.1...v6.0.2) (2023-06-27)


Expand Down
5 changes: 3 additions & 2 deletions README.MD
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ If you use Angular 5, you must use v1.5.2 or earlier
Latest version available for each version of Angular

| ngx-device-detector | Angular |
| ------------------- | ------- |
|---------------------|---------|
| 1.3.3 | 7.x |
| 1.3.5 | 8.x |
| 1.4.1 | 9.x |
Expand All @@ -56,6 +56,7 @@ Latest version available for each version of Angular
| 4.x.x | 14.x |
| 5.x.x | 15.x |
| 6.x.x | 16.x |
| 7.x.x | 17.x |

## Installation

Expand Down Expand Up @@ -213,4 +214,4 @@ If you like the library and want to support, you can do it by buying me a coffee
class="bmac"
href="https://www.buymeacoffee.com/codewithahsan">
<img src="https://img.buymeacoffee.com/button-api/?text=Buy me a coffee&emoji=&slug=codewithahsan&button_colour=BD5FFF&font_colour=ffffff&font_family=Comic&outline_colour=000000&coffee_colour=FFDD00" />
</a>
</a>
10 changes: 5 additions & 5 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,18 @@
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "demo:build"
"buildTarget": "demo:build"
},
"configurations": {
"production": {
"browserTarget": "demo:build:production"
"buildTarget": "demo:build:production"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "demo:build"
"buildTarget": "demo:build"
}
},
"e2e": {
Expand Down Expand Up @@ -125,7 +125,7 @@
}
},
"serve-ssr": {
"builder": "@nguniversal/builders:ssr-dev-server",
"builder": "@angular-devkit/build-angular:ssr-dev-server",
"options": {
"browserTarget": "demo:build",
"serverTarget": "demo:server"
Expand All @@ -138,7 +138,7 @@
}
},
"prerender": {
"builder": "@nguniversal/builders:prerender",
"builder": "@angular-devkit/build-angular:prerender",
"options": {
"browserTarget": "demo:build:production",
"serverTarget": "demo:server:production",
Expand Down
24 changes: 24 additions & 0 deletions docs/coverage.html
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,30 @@
<span class="coverage-count">(4/17)</span>
</td>
</tr>
<tr class="low">
<td>
<!-- miscellaneous -->
<a href="./miscellaneous/variables.html#REQUEST">projects/demo/src/express.tokens.ts</a>
</td>
<td>variable</td>
<td>REQUEST</td>
<td align="right" data-sort="0">
<span class="coverage-percent">0 %</span>
<span class="coverage-count">(0/1)</span>
</td>
</tr>
<tr class="low">
<td>
<!-- miscellaneous -->
<a href="./miscellaneous/variables.html#RESPONSE">projects/demo/src/express.tokens.ts</a>
</td>
<td>variable</td>
<td>RESPONSE</td>
<td align="right" data-sort="0">
<span class="coverage-percent">0 %</span>
<span class="coverage-count">(0/1)</span>
</td>
</tr>
<tr class="low">
<td>
<!-- miscellaneous -->
Expand Down
22 changes: 11 additions & 11 deletions docs/dependencies.html
Original file line number Diff line number Diff line change
Expand Up @@ -51,25 +51,25 @@
</ol>
<ul class="dependencies-list">
<li>
<b>@angular/animations</b> : ~16.0.1</li>
<b>@angular/animations</b> : ~17.0.2</li>
<li>
<b>@angular/common</b> : ~16.0.1</li>
<b>@angular/common</b> : ~17.0.2</li>
<li>
<b>@angular/compiler</b> : ~16.0.1</li>
<b>@angular/compiler</b> : ~17.0.2</li>
<li>
<b>@angular/core</b> : ~16.0.1</li>
<b>@angular/core</b> : ~17.0.2</li>
<li>
<b>@angular/forms</b> : ~16.0.1</li>
<b>@angular/forms</b> : ~17.0.2</li>
<li>
<b>@angular/platform-browser</b> : ~16.0.1</li>
<b>@angular/platform-browser</b> : ~17.0.2</li>
<li>
<b>@angular/platform-browser-dynamic</b> : ~16.0.1</li>
<b>@angular/platform-browser-dynamic</b> : ~17.0.2</li>
<li>
<b>@angular/platform-server</b> : ~16.0.1</li>
<b>@angular/platform-server</b> : ~17.0.2</li>
<li>
<b>@angular/router</b> : ~16.0.1</li>
<b>@angular/router</b> : ~17.0.2</li>
<li>
<b>@nguniversal/express-engine</b> : ~16.0.1</li>
<b>@angular/ssr</b> : ^17.0.0</li>
<li>
<b>conventional-changelog-cli</b> : ~2.2.2</li>
<li>
Expand All @@ -81,7 +81,7 @@
<li>
<b>tslib</b> : ~2.4.1</li>
<li>
<b>zone.js</b> : ~0.13.0</li>
<b>zone.js</b> : ~0.14.2</li>
</ul>


Expand Down
2 changes: 1 addition & 1 deletion docs/images/coverage-badge-documentation.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,10 @@ <h2 id="dependencies">Dependencies</h2>
<td>6.x.x</td>
<td>16.x</td>
</tr>
<tr>
<td>7.x.x</td>
<td>17.x</td>
</tr>
</tbody>
</table>
<h2 id="installation">Installation</h2>
Expand Down
2 changes: 1 addition & 1 deletion docs/injectables/UniversalDeviceDetectorService.html
Original file line number Diff line number Diff line change
Expand Up @@ -983,7 +983,7 @@ <h3 id="inputs">
import { AppModule } from &#x27;./app.module&#x27;;
import { AppComponent } from &#x27;./app.component&#x27;;
import { Inject, Injectable, Optional, PLATFORM_ID } from &#x27;@angular/core&#x27;;
import { REQUEST } from &#x27;@nguniversal/express-engine/tokens&#x27;;
import { REQUEST } from &#x27;../express.tokens&#x27;;
import { Request } from &#x27;express&#x27;;
import { DeviceDetectorService } from &#x27;ngx-device-detector&#x27;;
import { isPlatformServer } from &#x27;@angular/common&#x27;;
Expand Down
6 changes: 3 additions & 3 deletions docs/js/menu-wc.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,13 @@ customElements.define('compodoc-menu', class extends HTMLElement {
<a href="modules/AppServerModule.html" data-type="entity-link" >AppServerModule</a>
<li class="chapter inner">
<div class="simple menu-toggler" data-toggle="collapse" ${ isNormalMode ?
'data-target="#components-links-module-AppServerModule-94a9da4d75dda4a53e92dbb13389b51d4c791caa9166473d2b9060e30e599a5aa6f25f890a162f77ab222236a0d233186190dbbf890b21c6d6fbc351050563b2"' : 'data-target="#xs-components-links-module-AppServerModule-94a9da4d75dda4a53e92dbb13389b51d4c791caa9166473d2b9060e30e599a5aa6f25f890a162f77ab222236a0d233186190dbbf890b21c6d6fbc351050563b2"' }>
'data-target="#components-links-module-AppServerModule-d50c3f18b406204aed3d5617cb54f0da303fa7bf2086b26e37750ca799f7bb468bf10ab97a9f4f65c2ae916b077778d093522f0dd4f6d08be7fa0c6aaa61cf9d"' : 'data-target="#xs-components-links-module-AppServerModule-d50c3f18b406204aed3d5617cb54f0da303fa7bf2086b26e37750ca799f7bb468bf10ab97a9f4f65c2ae916b077778d093522f0dd4f6d08be7fa0c6aaa61cf9d"' }>
<span class="icon ion-md-cog"></span>
<span>Components</span>
<span class="icon ion-ios-arrow-down"></span>
</div>
<ul class="links collapse" ${ isNormalMode ? 'id="components-links-module-AppServerModule-94a9da4d75dda4a53e92dbb13389b51d4c791caa9166473d2b9060e30e599a5aa6f25f890a162f77ab222236a0d233186190dbbf890b21c6d6fbc351050563b2"' :
'id="xs-components-links-module-AppServerModule-94a9da4d75dda4a53e92dbb13389b51d4c791caa9166473d2b9060e30e599a5aa6f25f890a162f77ab222236a0d233186190dbbf890b21c6d6fbc351050563b2"' }>
<ul class="links collapse" ${ isNormalMode ? 'id="components-links-module-AppServerModule-d50c3f18b406204aed3d5617cb54f0da303fa7bf2086b26e37750ca799f7bb468bf10ab97a9f4f65c2ae916b077778d093522f0dd4f6d08be7fa0c6aaa61cf9d"' :
'id="xs-components-links-module-AppServerModule-d50c3f18b406204aed3d5617cb54f0da303fa7bf2086b26e37750ca799f7bb468bf10ab97a9f4f65c2ae916b077778d093522f0dd4f6d08be7fa0c6aaa61cf9d"' }>
<li class="link">
<a href="components/AppComponent.html" data-type="entity-link" data-context="sub-entity" data-context-id="modules" >AppComponent</a>
</li>
Expand Down
4 changes: 2 additions & 2 deletions docs/js/search/search_index.js

Large diffs are not rendered by default.

51 changes: 50 additions & 1 deletion docs/miscellaneous/variables.html
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,12 @@ <h3 id="index">Index</h3>
<li>
<a href="#OS_VERSIONS_RE_MAP" title="projects/ngx-device-detector/src/lib/device-detector.constants.ts" ><b>OS_VERSIONS_RE_MAP</b>&nbsp;&nbsp;&nbsp;(projects/.../device-detector.constants.ts)</a>
</li>
<li>
<a href="#REQUEST" title="projects/demo/src/express.tokens.ts" ><b>REQUEST</b>&nbsp;&nbsp;&nbsp;(projects/.../express.tokens.ts)</a>
</li>
<li>
<a href="#RESPONSE" title="projects/demo/src/express.tokens.ts" ><b>RESPONSE</b>&nbsp;&nbsp;&nbsp;(projects/.../express.tokens.ts)</a>
</li>
<li>
<a href="#TABLETS_RE" title="projects/ngx-device-detector/src/lib/device-detector.constants.ts" ><b>TABLETS_RE</b>&nbsp;&nbsp;&nbsp;(projects/.../device-detector.constants.ts)</a>
</li>
Expand Down Expand Up @@ -181,7 +187,7 @@ <h3></h3> <table class="table table-sm table-bordered">
</tr>
<tr>
<td class="col-md-4">
<i>Default value : </i><code>(mainModule &amp;&amp; mainModule.filename) || &#x27;&#x27;</code>
<i>Default value : </i><code>mainModule &amp;&amp; mainModule.filename || &#x27;&#x27;</code>
</td>
</tr>

Expand Down Expand Up @@ -1190,6 +1196,49 @@ <h3></h3> <table class="table table-sm table-bordered">
</tr>


</tbody>
</table>
</section>
<h3>projects/demo/src/express.tokens.ts</h3>
<section>
<h3></h3> <table class="table table-sm table-bordered">
<tbody>
<tr>
<td class="col-md-4">
<a name="REQUEST"></a>
<span class="name">
<span ><b>REQUEST</b></span>
<a href="#REQUEST"><span class="icon ion-ios-link"></span></a>
</span>
</td>
</tr>
<tr>
<td class="col-md-4">
<i>Default value : </i><code>new InjectionToken&lt;Request&gt;(&#x27;REQUEST&#x27;)</code>
</td>
</tr>


</tbody>
</table>
<table class="table table-sm table-bordered">
<tbody>
<tr>
<td class="col-md-4">
<a name="RESPONSE"></a>
<span class="name">
<span ><b>RESPONSE</b></span>
<a href="#RESPONSE"><span class="icon ion-ios-link"></span></a>
</span>
</td>
</tr>
<tr>
<td class="col-md-4">
<i>Default value : </i><code>new InjectionToken&lt;Response&gt;(&#x27;RESPONSE&#x27;)</code>
</td>
</tr>


</tbody>
</table>
</section>
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/AppServerModule.html
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ <h3>Bootstrap<a href="https://angular.io/api/core/NgModule#bootstrap" target="_b
import { AppModule } from &#x27;./app.module&#x27;;
import { AppComponent } from &#x27;./app.component&#x27;;
import { Inject, Injectable, Optional, PLATFORM_ID } from &#x27;@angular/core&#x27;;
import { REQUEST } from &#x27;@nguniversal/express-engine/tokens&#x27;;
import { REQUEST } from &#x27;../express.tokens&#x27;;
import { Request } from &#x27;express&#x27;;
import { DeviceDetectorService } from &#x27;ngx-device-detector&#x27;;
import { isPlatformServer } from &#x27;@angular/common&#x27;;
Expand Down
2 changes: 1 addition & 1 deletion docs/properties.html
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
</ol>
<ul class="properties-list">
<li>
<b>Version</b> : 6.0.2</li>
<b>Version</b> : 7.0.0</li>
<li>
<b>Keywords</b> : angular, device, device detector, device detection, ngx-device-detector, angular device detector, angular5, angular6, angular7, angular8</li>
<li>
Expand Down
Loading

0 comments on commit 934c448

Please sign in to comment.