Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: /save and /load saves and restores the edited-files list #1620

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

jerzydziewierz
Copy link

Frequently used feature: store and load the list of editable and read-only workspace file names.

Copy link
Author

@jerzydziewierz jerzydziewierz Sep 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added the save/load commands
  • Re-arranged the list to list frequently used commands first
  • all other commands left as-is

@jerzydziewierz
Copy link
Author

@paul-gauthier may I ask for an indication -- can this be merged, or should I drop it?

@paul-gauthier
Copy link
Collaborator

Thanks for your interest in aider and for taking the time to work on this PR. Unfortunately, I don't think I'll be able to merge this it. I like the concept and I know other users are interested in something like this. But the UX and implementation details in this PR probably aren't appropriate to merge.

@jerzydziewierz
Copy link
Author

I appreciate the time you took to look at it.

Being a recent pro dev on a large legacy project, I also appreciate that my implementation may be not suitable for this particular code base.

Still, you did not say to "just drop it" -- may I ask for a word of a guidance, what can I improve about it, to make it compatible with your code, please?

@jbellis
Copy link
Contributor

jbellis commented Oct 9, 2024

I also think this would be useful. How about if we narrowed the scope to simplify the UX? I think we get 90% of the benefit with 10% of the complexity.

  1. Modify the no-argument drop to save the state in memory before clearing the active state
  2. Add a new command (undrop?) to load the most recently dropped context

This addresses the most common use case (I have a complex context but I need to narrow it temporarily so I don't confuse the LLM for a surgical edit, before continuing with the bigger project) without adding complexity around marshaling to files etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants