AIK-6314 Attack Wave Detection & Stats #474
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also renames wrongly named "query_params_contain_dangerous_payload"
…tack wave detector
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
aikido_zen/vulnerabilities/attack_wave_detection/attack_wave_detector.py
Outdated
Show resolved
Hide resolved
aikido_zen/background_process/cloud_connection_manager/on_detected_attack_wave.py
Show resolved
Hide resolved
aikido_zen/vulnerabilities/attack_wave_detection/is_web_scan_method.py
Outdated
Show resolved
Hide resolved
aikido_zen/vulnerabilities/attack_wave_detection/query_params_contain_dangerous_strings.py
Outdated
Show resolved
Hide resolved
aikido_zen/vulnerabilities/attack_wave_detection/is_web_scan_path.py
Outdated
Show resolved
Hide resolved
aikido_zen/vulnerabilities/attack_wave_detection/attack_wave_detector.py
Show resolved
Hide resolved
…cify it contains malicious HTTP methods for web scan detection. More info
| blocked=queue_attack_item[2], | ||
| stack=queue_attack_item[3], | ||
| ) | ||
| # Queue can contain multiple types of events (attack, attack wave) |
There was a problem hiding this comment.
Comment explains what the queue contains rather than why multiple event types are needed or design rationale. More info
| def set_as_current_context(self): | ||
| """ | ||
| Set the current context | ||
| Set the current context, called every time we change the context. |
There was a problem hiding this comment.
Comment restates obvious method mechanics without explaining why context setting is needed. More info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://aikido.atlassian.net/browse/AIK-6314