Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example #1

Merged
merged 16 commits into from
Aug 9, 2022
Merged

Add example #1

merged 16 commits into from
Aug 9, 2022

Conversation

tomaszczura
Copy link
Contributor

No description provided.

@dwilt
Copy link
Contributor

dwilt commented Aug 8, 2022

@tomaszczura don't forget to update the README.md with some getting a started example too.. just some basic code.

@tomaszczura tomaszczura requested a review from dwilt August 9, 2022 10:02
package.json Outdated
@@ -1,14 +1,21 @@
{
"name": "@air/react-memoized-context",
"version": "1.0.0",
Copy link
Contributor

@dwilt dwilt Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "1.0.0",

I don't think you need to version it - and I'm curious to see if it will handle it for us

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I wil revert that

import { UsersTeamContextValue, UserTeamContextActions } from './usersTeamContextTypes';

export const usersTeamContextDispatch = (state: UsersTeamContextValue, action: UserTeamContextActions) => {
console.log('usersTeamContextDispatch', action);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want this in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

@tomaszczura tomaszczura marked this pull request as ready for review August 9, 2022 12:42
@tomaszczura tomaszczura merged commit a1507ec into main Aug 9, 2022
@tomaszczura tomaszczura deleted the feature/add-example branch August 10, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants