-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup default PR templates #1
base: main
Are you sure you want to change the base?
Conversation
My 2 cents:
For the other info, I'd rather put them in the Jira item and/or Confluence. I also think this would be nice to enforce the commit message format (using Conventional Commit in instance). But it's another story. |
the idea is more to have some base idea to fill in the description, not to enforce everything, and help PR creator, first-timer or not to avoid the "white page syndrom" for ex part of the template include a checklist of what we should have done outside the PR including documenting correctly the jira issue
Well ... since the commits are actually squashed in the end not sure this would be really useful |
Co-authored-by: Jacques LESCOT <jacques.lescot@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are aspects of your template that may be important for some changes, but overkill for others (I don't think it is possible to get a one-size-fits-all for this kind of thing).
Personally, I would greatly simplify this to (this may even be too much as they have to delete it each time, but maybe gives a little more instruction):
PLTFRS-XXX - Short Description of the Change
Please add details to provide the reviewers context about the change. This PR description will also be used as the merge commit and release description - so describe the change so that future developers understand what was done and why.
While I like the level of detail included in the template, I think it's overkill for most repos. I could see larger repos requiring more information, but this is really hard to generalize. Some repos may want to focus on testing or visualizations for example. For the general use case, I would just go w/something like Allen suggested. |
Co-authored-by: Jacques LESCOT <jacques.lescot@gmail.com>
First attempt to propose a generic default PR description template for the org
Any input appreciated