Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup default PR templates #1

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

setup default PR templates #1

wants to merge 6 commits into from

Conversation

bplessis-swi
Copy link
Contributor

First attempt to propose a generic default PR description template for the org
Any input appreciated

@bplessis-swi bplessis-swi self-assigned this Dec 11, 2024
@bplessis-swi bplessis-swi added documentation Improvements or additions to documentation help wanted Extra attention is needed question Further information is requested labels Dec 11, 2024
@cthirouin-swi
Copy link

cthirouin-swi commented Dec 11, 2024

My 2 cents:
It's nice on paper but I doubt most of the users will fill it all on each PR. In instance, av-backend repo has a PR template and it's rarely used.
I'd rather by pragmatic and have a sort of minimum viable PR template which would include:

  • a link to the Jira item
  • a short description of the technical modifications made
  • (optional) a longer description to give some technical context to the reviewers
  • (optional) actions to be done before merging/deploying

For the other info, I'd rather put them in the Jira item and/or Confluence.

I also think this would be nice to enforce the commit message format (using Conventional Commit in instance). But it's another story.

@bplessis-swi
Copy link
Contributor Author

My 2 cents: It's nice on paper but I doubt most of the users will fill it all on each PR.

the idea is more to have some base idea to fill in the description, not to enforce everything, and help PR creator, first-timer or not to avoid the "white page syndrom"

for ex part of the template include a checklist of what we should have done outside the PR including documenting correctly the jira issue

I'd rather by pragmatic and have a sort of minimum viable PR template which would include:
we can definitely reduce it yes

I also think this would be nice to enforce the commit message format (using Conventional Commit in instance). But it's another story.

Well ... since the commits are actually squashed in the end not sure this would be really useful

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Co-authored-by: Jacques LESCOT <jacques.lescot@gmail.com>
Copy link

@aservedio-swi aservedio-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are aspects of your template that may be important for some changes, but overkill for others (I don't think it is possible to get a one-size-fits-all for this kind of thing).

Personally, I would greatly simplify this to (this may even be too much as they have to delete it each time, but maybe gives a little more instruction):

PLTFRS-XXX - Short Description of the Change

Please add details to provide the reviewers context about the change. This PR description will also be used as the merge commit and release description - so describe the change so that future developers understand what was done and why.

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@cin
Copy link

cin commented Dec 12, 2024

While I like the level of detail included in the template, I think it's overkill for most repos. I could see larger repos requiring more information, but this is really hard to generalize. Some repos may want to focus on testing or visualizations for example. For the general use case, I would just go w/something like Allen suggested.

Co-authored-by: Jacques LESCOT <jacques.lescot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants