Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build flag WLED_DISABLE_ADALIGHT will break the settings/sync #4230

Closed
dosipod opened this issue Oct 27, 2024 · 2 comments
Closed

Build flag WLED_DISABLE_ADALIGHT will break the settings/sync #4230

dosipod opened this issue Oct 27, 2024 · 2 comments
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master

Comments

@dosipod
Copy link
Contributor

dosipod commented Oct 27, 2024

Compiling with WLED_DISABLE_ADALIGHT will break the settings/sync page and all the values in other areas will be empty.
This was part of the testing for c3 but it is also the case on classic esp32
image

@softhack007 softhack007 added bug needs investigation The bug has not yet been reproduced by me. Analysis or more details are needed. labels Oct 27, 2024
@blazoncek
Copy link
Collaborator

Disabling Adalight will also disable Improv and all serial communication. It is not really intended to disable Adalight.

Though there is a bug when it is disabled.

@blazoncek blazoncek added confirmed The bug is reproducable and confirmed and removed needs investigation The bug has not yet been reproduced by me. Analysis or more details are needed. labels Oct 27, 2024
@dosipod
Copy link
Contributor Author

dosipod commented Oct 27, 2024

We were looking for anything that could reduce the bin size on c3 to fit audio and maybe another usermod and below is the most common feature we could remove without too much impact

-D WLED_DISABLE_ADALIGHT
-D WLED_DISABLE_HUESYNC
-D WLED_DISABLE_LOXONE
-D WLED_DISABLE_INFRARED
-D WLED_DISABLE_ESPNOW

We do intend to do more tests for ALL other build flags even if not related to size just part of 15 testing if you see that to be useful but if anything is related to functionality testing after using a build flag then might take a bit of time . I am on mobile so I hope this is clear

blazoncek added a commit that referenced this issue Oct 27, 2024
- fix for #4172
- fix for #4230
- /json/live enabled when WS disabled
@blazoncek blazoncek added fixed in source This issue is unsolved in the latest release but fixed in master and removed enhancement labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master
Projects
None yet
Development

No branches or pull requests

3 participants