-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new buildenv for esp32s3dev_16MB_PSRAM_opi dev board (LilyGo T7-S3) #3569
new buildenv for esp32s3dev_16MB_PSRAM_opi dev board (LilyGo T7-S3) #3569
Conversation
…Go T7_s3 ESP32-S3-WROOM-1-N16R8
@raymondhardy thank you for the environment. However I do have some concerns. @softhack007 & @Aircoookie I am not happy with the growth of |
@blazoncek You're right, I think we need a new concept for al these "slightly different" boards. Especially with -S3/-S2/-C3 support added (and -C6 might join next year), collecting all possible buildenvs in In the special case of this PR, the [env:esp32s3dev_16MB_PSRAM_opi]
extends = env:esp32s3dev_8MB_PSRAM_opi
board_build.partitions = tools/WLED_ESP32_16MB.csv
board_upload.flash_size = 16MB Not sure what to do in the general case though ... its clear we cannot go on collecting buildenvs directly in Maybe See also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see details below.
In general, a maintainer decision is needed (as stated by @blazoncek) on how to collect board buildenvs in general. This clarification seems necessary before any approval can be made.
Sounds good. Just wanted to state that i did a new build with these changes and it works for the board! (I tested it with another board i had without any code on it) |
…-N16R8 new buildenv for esp32s3dev_16MB_PSRAM_opi dev board (LilyGo T7-S3)
…-N16R8 new buildenv for esp32s3dev_16MB_PSRAM_opi dev board (LilyGo T7-S3)
Adds new esp32s3dev_16MB_PSRAM_opi dev board to work with Lily Go T7_s3 ESP32-S3-WROOM-1-N16R8