Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new buildenv for esp32s3dev_16MB_PSRAM_opi dev board (LilyGo T7-S3) #3569

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

raymondhardy
Copy link
Contributor

Adds new esp32s3dev_16MB_PSRAM_opi dev board to work with Lily Go T7_s3 ESP32-S3-WROOM-1-N16R8

@blazoncek
Copy link
Collaborator

@raymondhardy thank you for the environment. However I do have some concerns.

@softhack007 & @Aircoookie I am not happy with the growth of platformio.ini file and inclusion of every possible dev board with different RAM/flash configuration there is.
I propose we move all but those included in release cycle into platformio_override.ini.sample. That way each and every person can have only their environments included without cluttering global platformio.ini.

@softhack007
Copy link
Collaborator

softhack007 commented Dec 5, 2023

@blazoncek You're right, I think we need a new concept for al these "slightly different" boards. Especially with -S3/-S2/-C3 support added (and -C6 might join next year), collecting all possible buildenvs in platformio.ini is very hard to maintain.

In the special case of this PR, the extends keyword could be used to make the real differences more obvious:

[env:esp32s3dev_16MB_PSRAM_opi]
extends = env:esp32s3dev_8MB_PSRAM_opi
board_build.partitions = tools/WLED_ESP32_16MB.csv
board_upload.flash_size = 16MB

Not sure what to do in the general case though ... its clear we cannot go on collecting buildenvs directly in platformio.ini. The good old times when esp32 4MB was all that matters are in the past - the future is more variants (classic, -S3, -S2, -C3, ...), more flash sizes (2MB, 4MB, 8MB, 16MB, ...) and more access modes (dio, qio, qio_qspi, qio_opi, opi_opi, ...) that are not compatible with each other.

Maybe platformio.ini should only provide the basic configs and consider major differences (like major chip/CPU variants, PSRAM, USB_CDC or HW Serial, different platform versions). Then specific boards would be added in another file.

See also:

Copy link
Collaborator

@softhack007 softhack007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see details below.

In general, a maintainer decision is needed (as stated by @blazoncek) on how to collect board buildenvs in general. This clarification seems necessary before any approval can be made.

platformio.ini Outdated Show resolved Hide resolved
platformio.ini Show resolved Hide resolved
@softhack007 softhack007 changed the title [Feat] Adds new esp32s3dev_16MB_PSRAM_opi dev board new buildenv for esp32s3dev_16MB_PSRAM_opi dev board Dec 5, 2023
@softhack007 softhack007 changed the title new buildenv for esp32s3dev_16MB_PSRAM_opi dev board new buildenv for esp32s3dev_16MB_PSRAM_opi dev board (LilyGo T7-S3) Dec 5, 2023
platformio.ini Outdated Show resolved Hide resolved
@raymondhardy
Copy link
Contributor Author

ecision is needed (as stated by @blazoncek) on how to collect board buildenvs in general. This clarification seems necessary before any approval can be made.

Sounds good. Just wanted to state that i did a new build with these changes and it works for the board! (I tested it with another board i had without any code on it)

@softhack007 softhack007 merged commit 51b3d7c into Aircoookie:main Jan 3, 2024
12 checks passed
@softhack007 softhack007 added the board request PR adding support for a specific board. label Jan 3, 2024
softhack007 added a commit to MoonModules/WLED that referenced this pull request Jan 8, 2024
…-N16R8

new buildenv for esp32s3dev_16MB_PSRAM_opi dev board (LilyGo T7-S3)
Djelibeybi pushed a commit to Djelibeybi/WLED-MM that referenced this pull request Jan 15, 2024
…-N16R8

new buildenv for esp32s3dev_16MB_PSRAM_opi dev board (LilyGo T7-S3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board request PR adding support for a specific board. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants